Skip to content

Allow the repository image symlink in previews #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Blargian wants to merge 1 commit into from
Closed

Allow the repository image symlink in previews #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/site-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,13 +136,17 @@ jobs:
path: site
persist-credentials: false

- name: Reject symbolic links in uploaded source
- name: Reject unsafe symbolic links in uploaded source
run: |
symlink="$(find site -type l -print -quit)"
if [[ -n "$symlink" ]]; then
echo "Fork and branch previews may not upload symbolic links: $symlink" >&2
while IFS= read -r -d '' symlink; do
relative_path="${symlink#site/}"
target="$(readlink "$symlink")"
if [[ "$relative_path" == "public/images" && "$target" == "../images" ]]; then
continue
fi

@cursor cursor Bot Sep 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowlist misses existing img symlink

High Severity

The new allowlist accepts only public/images → ../images, but the repository also ships public/img → ../img. The preview guard still rejects that existing link, so the upload fails before Vercel can build.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 3ebed95. Configure here.

echo "Fork and branch previews may not upload symbolic links: $relative_path -> $target" >&2
exit 1
fi
done < <(find site -type l -print0)

- name: Verify the checked-out revision
working-directory: site
Expand Down
Loading