Skip to content

fix(ci): cancel tests when pull requests close - #634

Merged
seonghobae merged 2 commits into
docs/decompose-adr-0133-0137-current-mainfrom
fix/cancel-tests-on-pr-close
Aug 25, 2026
Merged

fix(ci): cancel tests when pull requests close#634
seonghobae merged 2 commits into
docs/decompose-adr-0133-0137-current-mainfrom
fix/cancel-tests-on-pr-close

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Outcome

  • emit a pull_request.closed Tests workflow run in the existing per-PR concurrency group
  • let GitHub cancel the obsolete in-progress test run before a runner is allocated
  • skip backend and frontend jobs on the close event, preserving normal push/open/synchronize/reopen coverage

This is stacked on #631 so its exact queue baseline remains the parent authority. After #631 merges, retarget this PR to main and re-verify the exact head.

Root-cause evidence

Two Tests runs for already merged PRs #627 and #628 continued occupying the available runner slots while 54 newer runs remained queued. Manual cancellation released the stale work, but the existing central close workflow was itself queued behind those runs. The repository Tests workflow already had the correct per-PR concurrency group; adding the close event lets GitHub apply cancel-in-progress without waiting for a job runner.

Verification

  • uv run --extra dev pytest -q tests/test_tests_workflow_contract.py tests/test_documentation_hygiene.py (6 passed)
  • actionlint .github/workflows/tests.yml
  • git diff --check

No runtime product or UI surface changed; Figma and screenshot review do not apply.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9736f243-696d-4d5d-91b1-13be391744c0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment thread .github/workflows/tests.yml
@seonghobae
seonghobae merged commit 24dbce0 into docs/decompose-adr-0133-0137-current-main Aug 25, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant