feat(ui): add one-time HR export delivery confirmation states - #131
Draft
seonghobae wants to merge 8 commits into
Draft
feat(ui): add one-time HR export delivery confirmation states#131seonghobae wants to merge 8 commits into
seonghobae wants to merge 8 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer-visible interaction gap
The active HR Workspace stack has shared protected-read states in #130, while the governed export owner stack #75 → #120 defines high-risk human review and at-most-once one-time delivery semantics. This dependency-first Orgmetra-only child adds the workflow-specific export interaction proof without creating another export backend, changing HR data, or mutating a dedicated-writer dependency.
The UI makes the safe next action explicit across the consequential export lifecycle: explicit high-risk confirmation before any delivery attempt; one confirmed-ready handoff state; busy/disabled duplicate-send prevention while publishing; read-only receipt handling after successful delivery; a fail-closed indeterminate state that says do not send again; reconcile the existing delivery reference; and actionable purpose/authorization denial. Component-state evidence carries no protected HR values, identifiers, destination addresses, credentials, compensation, ratings, or model output.
Design authority and dependencies
feat/hr-workspace-protected-read-state@b3b30058a79174000919d566fbbb1fdad80c62bf.Orgmetra Baselinefilexu1ZK1zmtFcDep95R8oE9O, Storybook Inventory node1:64, was re-read without mutation. It explicitly requiresdefault / hover / focus / disabled / loading / validation-error / read-only / high-risk-confirmationstates. This child consumes that published requirement and adds no competing Figma geometry.RED → root-cause implementation
90486b897f39ffc6aa560087808651a12db9bd0fdefined one-time export review/publishing/delivered/indeterminate/denied behavior before production/story artifacts existed.30351aed0b59839255d21dc6cfdd50eb481cf429materialized the exact-head quality gate. Hosted run33070326964, job98510595941, acquired a runner, checked out the exact SHA, proved the checkout, set up Node, and then failed atRun one-time export interaction contract with exact coverage. This is a genuine terminal RED at the missing owner implementation boundary; clean-checkout was skipped only because the contract step failed.293c0d88b8768bb685e6d1fccd83d0bceeb1edd7adds the distinctreadystate so UI confirmation cannot itself masquerade as backend authorization: confirmation becomes locked, exactly one delivery handoff is enabled, and the copy explicitly says the backend must still revalidate authority.9df1f8f6a9e86c065967cec0b1756d214dbdee1badds exact-state, value-minimized interaction semantics and static Figma-correlated markup.605dc18c9b2b415f578b58803d3d6ff32e5c026fprovidesReviewRequired,ConfirmedReady,Publishing,DeliveredReadOnly,DeliveryIndeterminate, andPermissionDeniedevidence.9c6b619b4fb537ee57bc7c8ec0ceb16af001ad5creuses the existing Orgmetra design system and keeps denied/indeterminate behavior perceptible without relying on color alone.332c24ce05eca2d5b5efd95ad2e3741036e0e229records the Figma authority plus final W3C WCAG 2.2 / WAI-ARIA 1.2 primary references without claiming conformance.8cfeb21f2bad73a9c7a4a60b1b7597e4779f429eadds dedicated traceability for the technical and semantic dependency boundaries, privacy minimization, no-republish ambiguity rule, and post-parent revalidation requirements.Exact-current-head evidence
Parent/base: #130
b3b30058a79174000919d566fbbb1fdad80c62bf.Child head:
8cfeb21f2bad73a9c7a4a60b1b7597e4779f429e.GitHub reports open · Draft · mergeable.
HR Workspace Export Delivery State Qualityrun33070554785, job98511379714, is terminal GREEN. The job checked out and asserted the exact child SHA, ran the one-time export interaction contract under Node 24 with exact 100% line / branch / function coverage thresholds, and passed clean-checkout.Fresh submitted reviews: none. Fresh review threads: none.
This is focused stack-local GREEN only. Parent #130 checks/reviews never transfer; #75/#120 backend evidence never transfers; and the child does not claim default-branch integration or production export authorization.
Stack / merge discipline
Keep Draft. Process #53 → #130 first. Before this interaction can be represented as commercially available product truth, the relevant export backend owner contracts must also be integrated or consumed through their then-current published boundary. After parent integration, retarget/reconcile against fresh
develop, refetch #75/#120 contract truth, and rerun every applicable browser/accessibility/Foundation/SAST/Security/Recovery/central workflow on one resulting exact head.Do not transfer parent/backend evidence, self-approve, use routine administrator bypass, race another lifecycle writer, weaken a gate, republish after an indeterminate delivery, or mutate another CWL repository.