feat: add governed compensation change review packet - #48
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough보상 변경 검토 패킷의 최소화된 데이터 계약과 fail-closed 검증을 추가했습니다. 패킷은 결정적 canonical JSON과 SHA-256 digest를 사용합니다. 회귀 테스트, 추적성 문서와 GitHub Actions 품질 게이트도 추가했습니다. Changes보상 변경 검토
Estimated code review effort: 4 (Complex) | ~60 minutes Merge Risk: 🟡 Moderate · up to The packet behavior is unchanged by the latest fix, but the current head is not merge-ready because a required review gate has failed and other required checks are still incomplete. Merge should wait until all required checks are terminally green and the required approval is obtained. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent Review current exact head |
|
@opencode-agent Please independently review exact current head |
|
@opencode-agent review exact head |
|
@opencode-agent Please independently review exact current head |
|
@opencode-agent Please independently review exact current head |
|
@opencode-agent Please independently review exact current head |
|
Verified the remaining CodeRabbit maintainability finding against exact head |
Buyer-visible scope
Adds a portable, value-minimized compensation-change review envelope before authoritative HRIS mutation or payroll execution. It binds tenant, Person, Employment, active Assignment/Job/Position snapshot, current/proposed compensation evidence, exact policy, pay-equity review, budget authorization, payroll-handoff provenance, requester/reviewer, effective date, and evidence version while excluding compensation values, protected-attribute values, credentials, and free-form case/model content. It remains human-review-only and grants no mutation or execution authority.
Current integrity boundary
The branch preserves the recorded-time repair: caller-owned mutable
tzinfostate is resolved once and detached into an exact built-in UTCdatetime, with indeterminate/hostile timestamp providers failing closed. It also preserves strict exact-type evidence validation, controlled governance constants, tenant/reference privacy boundaries, complete canonical field coverage, and process-local creation-bound evidence integrity. The process-local seal is defense-in-depth only and is not durable authorization, portable signing, persisted uniqueness, rehydration authority, or a substitute for immutable audit/outbox evidence.This successor head also repairs package-quality evidence freshness. The package workflow previously omitted root/shared Python test/runtime and clean-checkout configuration from its PR path filter. A structural regression was added first at
118a3a385a76b2a791a107465ad51e213e4477de, then the workflow was repaired to retrigger on.gitignore,.python-version, root/sharedconftest.py, rootpyproject.toml,pytest.ini,setup.cfg, andtox.ini; CHANGELOG and traceability were synchronized. The latest Devin observation on this trigger contract is resolved: all eight shared paths are now present.Exact-current-head evidence
b9e487cc1e07267ff69d222b0917ec108804b799develop@9e3e4847510e1e612b48474ba42b177b8ed824df33279024704, job99170874250: terminal SUCCESS on this exact head; 78 tests passed, owned production 190/190 statements and 54/54 branches (100.00%), compile and clean-checkout proof GREEN.33279024705: terminal SUCCESS.33279024698: terminal SUCCESS.33279024690: terminal SUCCESS.33279024680: OSV99170874427, Trivy99170874445, and Scorecard99170874455are terminal GREEN; dependency-review job99170874472is terminal FAILURE at the central dependency-review support/control-plane boundary, before the pinned Dependency Review action executes. Exact consumer evidence is routed through existing owner handoffContextualWisdomLab/.github#810.33279023383, job99171902498: terminal FAILURE because no authenticatedopencode-agent/opencode-agent[bot]formalAPPROVEDorCHANGES_REQUESTEDreview exists on this exact head. Existing owner handoffContextualWisdomLab/.github#624has the exact-current canary; deterministic/model-unavailable/unsupported fallback and predecessor verdicts are non-transferable.33279023408, job99170871640: trusted-source materialization, repository-scoped reviewer token, target visibility, and all five provider credential checks succeed; the endpoint feed returns413 request_too_large, the live OpenRouter ZDR feed is selected, and the pinned contextual-orchestrator sidecar exits status 1 before/healthz. The actual Noema review/verdict never executes. Existing owner handoffContextualWisdomLab/.github#1399has the exact-current canary.total_count=0. No authoritative Strix run/check materialized for this head; absence is non-passing. Existing owner handoffContextualWisdomLab/.github#1327has the exact-current materialization canary.CHANGES_REQUESTEDverdict.Merge discipline
This PR is not merge-ready. Before integration require the unchanged exact head, or a fresh successor head revalidated from zero, to satisfy every applicable local and central gate, including terminal Dependency Review/Security, authoritative exact-head OpenCode/Noema/Strix evidence, resolved required conversations, and qualifying independent non-author approval after the last push. Queued, pending, skipped-required, cancelled, absent, neutral, failed, stale, predecessor, status-only, fallback-only, and model-only evidence is non-passing.
The remaining central failures/absence are foreign-owner boundaries. Do not self-approve, use routine administrator bypass, weaken a gate, transfer predecessor evidence, manufacture review/security evidence, add an Orgmetra shim for a foreign owner, or mutate another dedicated-writer repository.
Scope / non-claims
This packet does not calculate or authorize compensation, payroll, taxes, pay-equity findings, or employment decisions; it does not prove policy/legal sufficiency or successful downstream execution; and it does not claim certification, deployed production integrations, durable signing infrastructure, or commercial release.