merge queue: checking #458 on main (94593f3), stacked on #446 and #457 - #461
Closed
mergify[bot] wants to merge 6 commits into
Closed
merge queue: checking #458 on main (94593f3), stacked on #446 and #457#461mergify[bot] wants to merge 6 commits into
mergify[bot] wants to merge 6 commits into
Conversation
check_skill_trigger_policy.py failed on main because the generated block in docs/skill-triggers.md lagged the skills on disk, so every PR's make-pr preflight failed on a file the PR never touched. This is the output of scripts/check_skill_trigger_policy.py --write, nothing else. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnua5cuAAF1ey1b7zRqJCC Change-Id: I5462317f830a12287fbc5cfd3dff4be8b52e2945
A PR that already exists gets one of two treatments, read off its current diff: stack another commit when its claim still holds and the addition is small, or overwrite the branch when the diff stopped matching the claim -- it carries work already on the base, it mixes review units, or it ships a second claim. The record that gets read later is the final diff and body, so such a branch is rewritten rather than explained in Slice Rationale. Overwriting requires a backup branch and --force-with-lease; a lease failure means another session moved the branch, so re-read it instead of forcing. The choice is mechanical and is not a question for the user. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnua5cuAAF1ey1b7zRqJCC Change-Id: I3839f20ff1f27f9375ec7cf84816e23747986b0a
Five phrase lists under engine/hooks/diu-stop/phrases/ name the kinds of wording that left the user asking what a reply meant: words the assistant made up, raw code or setting names, internal tool names, tech jargon and abbreviations, and status words. Data and one test only; nothing reads them yet. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gnua5cuAAF1ey1b7zRqJCC Change-Id: I4860c82b5b8a8a6b84a9397e289c7023fd5d7730
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#458 is queued for merge on branch main (94593f3).
Stacked behind 2 pull requests queued ahead of this batch, not part of it. These checks run on a tip that also carries their commits, so a failure here can come from them as much as from #458.
Queued ahead of this batch:
This pull request has been created by Mergify to speculatively check the mergeability of #458.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
admin-bypassfor merge:check-success = lintcheck-success = testRequired conditions to stay in the queue:
-draftbase=mainlabel=admin-bypass