ci: decouple test job from vet so test regressions can't be skipped - #158
Merged
Conversation
A vet failure currently skips the entire tier 2+3 job graph, including test (race + coverage). This masked the DrainAlerts test breakage in PR #155, where vet failed on the trailer-strip force-push and the test job was silently skipped. The test job now depends only on [format] so the suite always runs and regressions surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
vetfailure currently skips the entire Tier 2+3 job graph (lint, test, security, smoke, module hygiene, public module graph, parity, secrets, markdown, deadcode, duplication, build, fuzz). This masked the DrainAlerts test breakage in PR #155, where vet failed on the trailer-strip force-push and the test job was silently skipped.Change:
testnowneeds: [format]only (not[format, vet]), so the race+coverage suite always runs and test regressions surface directly instead of being hidden behind an unrelated static-analysis failure.