Skip to content

ci: decouple test job from vet so test regressions can't be skipped #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patel230 merged 1 commit into from
Jul 31, 2026
Merged

ci: decouple test job from vet so test regressions can't be skipped #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,13 @@ jobs:
test:
name: test (race + coverage)
runs-on: ubuntu-latest
needs: [format, vet]
# NOTE: depends only on `format`, deliberately NOT on `vet`.
# A `vet` (or upstream) failure must never skip the test job — that
# historically masked real test regressions (see hawk PR #155, where
# DrainAlerts code shipped with failing tests because `test` was skipped
# when `vet` failed on the trailer-strip force-push). Tests must always
# run so regressions surface instead of being hidden.
needs: [format]
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
Expand Down
Loading