Fixup layer negotiation failure - #2026
Open
charles-lunarg wants to merge 4 commits into
Open
Conversation
If the loader calls vkNegotiateLoaderLayerInterfaceVersion and it fails either due to the version being unsupported or the call returned an error code, skip the layer rather than trying to use a lower interface version.
Add error enums for when negotiation of the interface version fails and when the loader cannot load vkGetInstanceProcAddr.
vkEnumerateDeviceLayerProperties currently returns all layers that are in the app_activated_layer_list, regardless of whether they successfully loaded the binary or not. This change makes it so that only layers with the lib_status of 'success' and 'not loaded' (which corresponds to meta layers), will be enumerated
|
CI Vulkan-Loader build queued with queue ID 104155. |
|
CI Vulkan-Loader build queued with queue ID 104184. |
|
CI Vulkan-Loader build # 3745 running. |
Also skip layers that failed to load while enumerating device extensions.
|
CI Vulkan-Loader build queued with queue ID 104239. |
|
CI Vulkan-Loader build # 3746 running. |
|
CI Vulkan-Loader build # 3746 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.