Skip to content

gtk_mesa_tests: Fix calculation in % - #4217

Merged
grandixximo merged 2 commits into
LinuxCNC:masterfrom
hdiethelm:fix_gtk_mesa_tests
Aug 2, 2026
Merged

gtk_mesa_tests: Fix calculation in %#4217
grandixximo merged 2 commits into
LinuxCNC:masterfrom
hdiethelm:fix_gtk_mesa_tests

Conversation

@hdiethelm

@hdiethelm hdiethelm commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

#4082 changed the time values from cycles to ns.

This broke the calculation of % values and the CPU clock is not needed any more.

Discovered here: #4199

TBD: Remove the CPU Speed read fully? I would say yes.

@zz912

zz912 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

TBD: Remove the CPU Speed read fully? I would say yes.

I say yes too.

@hdiethelm

Copy link
Copy Markdown
Contributor Author

^Rebased to master

@grandixximo grandixximo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I checked the calculation and it is correct: tmax and period are both in ns from HAL, so the CPU clock is indeed no longer needed.

I built and ran the panel from the branch. Python compiles and the glade file validates, so no blockers from my side.

One nitpick: the two GtkAdjustment objects adj_cpu_speed_nic and adj_cpu_speed_servo at the top of gtk_mesa_tests.glade (lines 4-13) are now orphaned; the spin buttons that referenced them were removed. Please delete them.

@hdiethelm
hdiethelm force-pushed the fix_gtk_mesa_tests branch from a6daed0 to c5dcb89 Compare August 2, 2026 08:37
LinuxCNC#4082 changed the time values
from cycles to ns.

This broke the calculation of % values and the CPU clock is not needed any more.
@hdiethelm
hdiethelm force-pushed the fix_gtk_mesa_tests branch from c5dcb89 to c05c991 Compare August 2, 2026 08:38
@hdiethelm

Copy link
Copy Markdown
Contributor Author

One nitpick: the two GtkAdjustment objects adj_cpu_speed_nic and adj_cpu_speed_servo at the top of gtk_mesa_tests.glade (lines 4-13) are now orphaned; the spin buttons that referenced them were removed. Please delete them.

Thanks, fixed + tested.

  1. force push: Fix
  2. force push: Rebase master

@grandixximo
grandixximo merged commit b51d0bc into LinuxCNC:master Aug 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants