gtk_mesa_tests: Fix calculation in % - #4217
Conversation
I say yes too. |
ace34d3 to
a6daed0
Compare
|
^Rebased to master |
grandixximo
left a comment
There was a problem hiding this comment.
Thanks for this. I checked the calculation and it is correct: tmax and period are both in ns from HAL, so the CPU clock is indeed no longer needed.
I built and ran the panel from the branch. Python compiles and the glade file validates, so no blockers from my side.
One nitpick: the two GtkAdjustment objects adj_cpu_speed_nic and adj_cpu_speed_servo at the top of gtk_mesa_tests.glade (lines 4-13) are now orphaned; the spin buttons that referenced them were removed. Please delete them.
a6daed0 to
c5dcb89
Compare
LinuxCNC#4082 changed the time values from cycles to ns. This broke the calculation of % values and the CPU clock is not needed any more.
c5dcb89 to
c05c991
Compare
Thanks, fixed + tested.
|
#4082 changed the time values from cycles to ns.
This broke the calculation of % values and the CPU clock is not needed any more.
Discovered here: #4199
TBD: Remove the CPU Speed read fully? I would say yes.