mesa_modbus: remove deprecated framework, superseded by hm2_modbus - #4530
Open
grandixximo wants to merge 1 commit into
Open
grandixximo wants to merge 1 commit into
grandixximo wants to merge 1 commit into
Conversation
Per the developer meeting decision, remove the mesa_modbus framework (modcompile + mesa_modbus.c.tmpl driver template) from master entirely. It was deprecated in 46074f8 in favor of the hm2_modbus driver with mesambccc-compiled MBCCB files, and the 2.9 branch retains it, so existing configurations keep documentation and migration support there. Remove the modbus source directory with its samples and README, the mesa_modbus driver doc and modcompile man page, the build rules, debian packaging entries, docs pipeline entries, and fix the two cross-references that pointed at the removed pages. A migration note is added to the 2.10 section of updating-linuxcnc.adoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the developer meeting decision: remove the old mesa_modbus framework from master, hm2_modbus is the way forward.
The framework (modcompile + mesa_modbus.c.tmpl + .mod samples) was deprecated in #4386 in favor of hm2_modbus with mesambccc-compiled MBCCB files. The 2.9 branch retains it (see #4396), so existing configurations keep working there with documentation and migration support.
This removes:
src/hal/drivers/mesa-hostmot2/modbus/(modcompile.py, template, samples, README)Two cross-references that pointed at the removed pages are fixed (mesambccc SEE ALSO, hm2_pktuart example), and a migration note is added to the 2.10 section of updating-linuxcnc.adoc. The note links to the 2.9 docs for the removed pages, following the existing precedent of the 2.8 upgrade link in the same file.
The "Parts from mesa_modbus.c.tmpl" attribution comment in hm2_modbus.c stays, it is historical credit, not a reference to live code.