Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first part in the migration to 64-bit HAL types. All the files involved in this PR are a rename action. For all Python code the new IntEnums are used:
HAL_FLOAT->hal.Type.REALHAL_BIT->hal.Type.BOOLHAL_IN->hal.Dir.INHAL_OUT->hal.Dir.OUTHAL_IO->hal.Dir.IONote that these files do not have any integer HAL types.
The new HAL type names are already available and will work as expected. These are all to create a contained and consistent set of new HAL types with a clean API break following. The set of files in this PR have been chosen so that they will not create any conflicts with the tracking branch in #4247. The set of files in this PR only reference floating point and boolean HAL types.
A second set of files, which have
[SU]32types, will follow without touching the integer types. The change of 32-bit to 64-bit will happen in one go with everything else. These lead-in PRs are just to reduce the patch size considerably (total patch is 446 files and this PR alone reduces it by 98 to 348).