Fix LuaJIT compatibility on dev - #2503
Open
JLawMcGraw wants to merge 2 commits into
Open
Conversation
Contributor
|
This syntax is part of LuaJIT v2.1 as of July 2026. Update your LuaJIT: LuaJIT/LuaJIT#1476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Recent dev changes introduced syntax accepted by Luau but not by the LuaJIT 2.1 runtime used by Path of Building and its test workflow. Attribute-node switching also recursively deep-copies references into the passive-tree graph, which greatly increases allocation and can exhaust LuaJIT table capacity during replay-heavy workloads.
This replaces the incompatible operators, optional chaining, continue statements, and arrow function with LuaJIT-compatible equivalents. It also switches attribute nodes with a shallow structural copy while copying the stat-description array that ReplaceNode mutates.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
N/A; this is runtime compatibility and passive-tree correctness.
Before screenshot:
N/A
After screenshot:
N/A