Self-host: sync TypedPropertyClassAssignCheck into compile spine (#31835) - #35708
Merged
PurHur merged 1 commit intoAug 29, 2026
Merged
Conversation
#35705 landed the AOT typed-property class assign helper but omitted spine coverage; ci-fast spine-sync was red with one missing inventory file. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
deleted the
agent/issue-spine-typed-property-class-assign-check-lane-b
branch
August 29, 2026 08:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/TypedPropertyClassAssignCheck.phptocompiler_lib_spine_smoke— landed in AOT: fix bare self/parent typed property assigns from locals (#31835) #35705 for AOT typed self/parent property assigns (Language: bare self/parent typed properties reject valid assignments — Zend accepts (?self/unions OK) (zend_execute / TypeCheck) #31835) but was missing from the spine, leavingcheck-selfhost-spine-coverage-syncred on master.Verification
Closes #31835 (spine follow-up from #35705)
Made with Cursor