fix: improve weather, configuration, and shell interactions - #3
Open
TroyMitchell911 wants to merge 9 commits into
Open
fix: improve weather, configuration, and shell interactions#3TroyMitchell911 wants to merge 9 commits into
TroyMitchell911 wants to merge 9 commits into
Conversation
Write generated Niri cursor settings to the Clavis namespace instead of the DMS configuration directory. Document the include path required to load the generated settings.
Open the weather settings page from the sidebar editor and provide validated manual location controls with automatic-location fallback. Synchronize location changes with the running shell through IPC.
Raise and activate the floating picker after it becomes visible so image and folder selection dialogs receive focus under tiling compositors.
Expand the input region while a Keystone popup is open and close the active popup on the first pointer press outside the pill.
Prefer an already running Secret Service and fall back to KWallet 6 when libsecret has no provider. Include the backend error detail when credential operations fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates a set of fixes and performance improvements discovered while deploying and testing Clavis in a live Niri session.
It improves Niri configuration isolation, weather configuration and credential storage, file picker focus, Keystone popup dismissal, launcher selection, left-sidebar performance, and configuration reload feedback.
Changes
Niri configuration isolation
~/.config/niri/clavis/cursor.kdlinstead of the DMS-managed configuration directory.Existing Niri configurations should include:
Weather location and forecast presentation
Weather credential storage
QTKEYCHAIN_BACKEND.This does not add a new external package dependency because Qt DBus is provided by the already-required Qt 6 base package.
File picker activation
Keystone popup dismissal
Launcher selection
Left-sidebar performance
Reload notifications
Validation
The following checks were run against the complete branch:
qmllinton every changed QML file — completed successfully.cmake --build core/build— completed successfully.env -u QT_QPA_PLATFORMTHEME QT_QPA_PLATFORM=offscreen ctest --test-dir core/build --output-on-failure— all 8 tests passed.git diff --check origin/main...HEAD— completed successfully.Manual validation was also performed in the running Niri/Clavis session:
The sidebar transition and weather scrolling improvements were additionally confirmed by the user.
Screenshots and recordings
The following UI evidence will be added during review: