Make the unfixable short-display-time test independent of the gap setting - #14592
Merged
Conversation
…ting Since #14576 the rule extends a short line into whatever gap there is to the next line. The test's next line started 20 ms after the short one, so it only stayed "unfixable" while the static MinimumMillisecondsBetweenLines was >= 20; other tests can change that setting, and CI on main failed with the 300 ms line extended to 320 ms. Start the next line back-to-back so there is no room for any gap value. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main (and on #14590) fails in
FixCommonErrorsUnfixableErrorsTests.Scan_ReportsErrorsThatCouldNotBeFixed: since #14576 "Fix short display time" extends into whatever gap exists, and the test's 20 ms gap was only "no room" while the staticMinimumMillisecondsBetweenLineswas still 24. Other tests can change it, so the 300 ms line got extended to 320 ms.The next line now starts back-to-back at 300 ms, so the case is unfixable for any gap value. Test-only change.
🤖 Generated with Claude Code