Skip to content

fix(diagnostics): publish the error shape rather than its text in three logs #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
Sep 18, 2026
+3 −3
Merged

fix(diagnostics): publish the error shape rather than its text in three logs #2970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion TablePro/Core/MCP/Outside/MCPRemoteToolCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ internal final class MCPRemoteToolCoordinator {
Self.logger.error(
"""
MCP server \(configuration.id, privacy: .public) did not list its tools: \
\(error.localizedDescription, privacy: .public)
\(error.publicLogShape, privacy: .public)
"""
)
await detachAll(serverId: configuration.id)
Expand Down
4 changes: 2 additions & 2 deletions TablePro/Views/Export/ExportTreeBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ struct ExportDriverMetadataReader: ExportMetadataReading {
return grouped
}
} catch {
Self.logger.warning("Export catalog read failed: \(error.localizedDescription, privacy: .public)")
Self.logger.warning("Export catalog read failed: \(error.publicLogShape, privacy: .public)")
return [:]
}
}
Expand Down Expand Up @@ -290,7 +290,7 @@ struct ExportTreeBuilder {
return try await reader.fetchTables(schema: isCurrentDatabase ? nil : database)
} catch {
Self.logger.warning(
"Export tree read no tables for \(database, privacy: .public): \(error.localizedDescription, privacy: .public)"
"Export tree read no tables for \(database, privacy: .public): \(error.publicLogShape, privacy: .public)"
)
return []
}
Expand Down
Loading