Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swiftlint lint --strictis red onmainright now, so the nextv*tag would fail its lint job before it built anything.Three sites log
error.localizedDescriptionat.public, which thepublic_error_text_in_logrule rejects at error severity: a driver or Foundation error's text carries row values, paths and server messages.MCPRemoteToolCoordinator, when a server does not list its toolsExportTreeBuilder, on a failed catalog read and on a database whose tables do not loadEach now publishes
error.publicLogShape, which is what every other call site in the app does and what the rule's own message asks for.Found by a CI audit, not by CI: lint only runs on a release tag today, so nothing reported these on the pull requests that introduced them.
swiftlint lint --strictis clean and the app builds.