fix: decide the content mode commands, name the payload digest, and wait out the stream producer - #2972
Merged
Conversation
…ait out the stream producer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's unit suite is red on four cases, all from #2384. This fixes three; the fourth,LogRedactionTests.noCallSitePublishesErrorText, is #2970.Menu validation coverage.
setContentModeFromMenu:andtoggleContentModeFromMenu:were decided invalidateMenuItemalone, so the pureresolvedEnablementleft them enabled by default, which is the state that ships a lit command over a window that cannot run it. They move to an arm beside the two AI query commands, which already read the same setting, and the now unused live helper goes.MCP audit log. The outbound tool line logged a variable called
fingerprintthat holds the SHA-256 prefix of the tool call's payload. In this surface a fingerprint means a pairing token's, which no log line may carry, and the guard reads the vocabulary rather than the value. It ispayloadDigestnow, which is what it is.Stream abort.
holdingTheStreamKeepsItAliveslept 0.6 seconds and then asserted the producer had run all 20 of its 20ms rows. On a loaded runner it had run 19. It waits for the producer instead, so it still asserts that holding the stream does not abort it, without asserting the runner's load.Also removes a pre-existing blank line after the opening brace that SwiftLint rejects once the file is linted.
The three suites pass locally, and
LogRedactionTestspasses with #2970 applied on top.