fix(hig): fix the failing tests on main - #2982
Merged
Merged
Conversation
…failed batch's banner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three failures
macOS Testshas hit on every recentmainrun.Unit: "No menu names itself with accessibilityLabel"
#2969 added
.accessibilityLabelto four menus: the JSON row inspector options, the AI chat model picker, Export's saved selections and the Users & Roles bulk actions. The guard from #2929 forbids that, because the modifier on a SwiftUIMenureplaces the name its label provides with nothing. Each name now sits on the label content, the same shapeResultSetMenuand #2929 use.AccessibleControlNameTestsstill passes, since it only needs the label string and the modifier in the file.UI:
ForeignKeyPickerUITests(both cases)Failing on every run since #2969, which gave each picker row
.accessibilityAddTraits(.isButton)and.accessibilityAction. The row's texts stopped reaching the tree as static texts, sostaticTexts["AC/DC"]never matched..accessibilityElement(children: .contain)ahead of them keeps the press action and the button trait on the row and its texts readable as their own elements.UI:
testRunAllLeavesTheUserTransactionOpenAfterAFailureA race in the test added by #2971, 2 of 3 runs. After the first batch fails, its banner stays up and the chooser reads "Result 3 of 3" until the next batch lands, so
chooser.title.contains("2") || banner.existswas already true before the second batch started. One CI run shows it directly:got Statement 3/3 failed: n.... The wait now requires two results and no banner.Not addressed
"The sample database never finished opening" hits a different test on each run, also on branches before #2969, and
UITestCase.waitForSampleDatabaseWindowalready documents it as runner contention. Retries usually clear it.Verification
MenuDisclosureIndicatorTests,AccessibleControlNameTests: 5/5 pass.ForeignKeyPickerUITests: both pass.QueryRunUITests: the changed case passed in two separate runs. Each run lost one other case toCritical process testmanagerd crashed(local environment), and each of those passed in the other run.swiftlint lint --stricton the changed files: clean.No CHANGELOG entry: #2969 and #2971 are both unreleased.