fix(archive): Delay StdBIGFile allocation until after archive validation

[CryoTheRenegade]

Clang-tidy found that StdBIGFileSystem::openArchiveFile allocated the archive object before checking whether the file opened or whether the BIG identifier was valid. Those two early-return paths leaked the object.

This matches the existing Win32BIGFileSystem allocation order.

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can switch off images and animations for a plain-text comment

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Prevent Std BIG archive leaks on validation failures

🐞 Bug fix 🕐 Less than 5 minutes

AI Description

• Defers StdBIGFile creation until the archive file and identifier are validated.
• Prevents leaked archive objects on failed opens and malformed BIG files.
• Aligns standard-device archive handling with the Win32 implementation.

Diagram

graph TD
  A["Open request"] --> B["Open file"] --> C{"File opened?"}
  C -- No --> F["Return null"]
  C -- Yes --> D{"Valid BIG ID?"}
  D -- No --> F
  D -- Yes --> E["Allocate archive"] --> G["Parse entries"] --> H["Return archive"]

Loading

High-Level Assessment

The allocation delay is the best targeted fix: it removes ownership obligations from both early-return paths and matches the established Win32 implementation. Broader RAII conversion was considered but would increase scope without improving these pre-allocation failure paths.

Files changed (1) +2 / -2

Bug fix (1) +2 / -2

StdBIGFileSystem.cppDefer StdBIGFile allocation until archive validation succeeds +2/-2

Defer StdBIGFile allocation until archive validation succeeds

• Moves 'StdBIGFile' construction below file-open and BIG-identifier validation. Failed opens and invalid archive headers therefore return without leaking an allocated archive object, matching Win32 allocation ordering.

Core/GameEngineDevice/Source/StdDevice/Common/StdBIGFileSystem.cpp