fix(clang-tidy): Accept both slashes so we can get the header diagnostics on Windows and Unix - #3225
Conversation
…tics on Windows and Unix Signed-off-by: Jacob Ledbetter <jledbetter460@gmail.com>
PR Summary by QodoFix cross-platform clang-tidy header diagnostic filtering
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1.
|
|
| Filename | Overview |
|---|---|
| .clang-tidy | The revised regex addresses the previously reported relative-path omission while supporting Unix and Windows separators. |
Reviews (2): Last reviewed commit: "fix(clang-tidy): Match relative header p..." | Re-trigger Greptile
Require slash-or-start before Core/Generals/Dependencies so both Core\Include\Foo.h and ...\Core\Include\Foo.h match. The previous pattern required a separator before the project root and dropped relative Windows and Unix paths. Co-authored-by: Cursor <cursoragent@cursor.com>
The old clang tidy config file ignored / file paths, so when running to check for diagnostics, it failed to find any headers on Windows (i.e Core\Include\Common/Foo.h).
This fixes that and adds an ExcludeHeader regex for the MaxSDK and and _deps so we aren't chasing our tails for stuff outside of the repo.