Skip to content

fix: use default timeout in request header #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikemikimike wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: use default timeout in request header #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/anthropic/_base_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,9 +461,7 @@ def _build_headers(self, options: FinalRequestOptions, *, retries_taken: int = 0
# lowest precedence first; any of these can be overridden or `Omit`-ted by the layers after it
headers, omitted = build_headers(
{
"x-stainless-timeout": str(options.timeout.read)
if isinstance(options.timeout, Timeout)
else str(options.timeout),
"x-stainless-timeout": str(timeout.read) if isinstance(timeout, Timeout) else str(timeout),
"x-stainless-retry-count": str(retries_taken),
**({"x-stainless-read-timeout": str(read_timeout)} if read_timeout is not None else {}),
**({idempotency_header: idempotency_key} if idempotency_header and idempotency_key else {}),
Expand Down
2 changes: 2 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ def test_request_timeout(self, client: Anthropic) -> None:
request = client._build_request(FinalRequestOptions(method="get", url="/foo"))
timeout = httpx2.Timeout(**request.extensions["timeout"]) # type: ignore
assert timeout == DEFAULT_TIMEOUT
assert request.headers["x-stainless-timeout"] == str(DEFAULT_TIMEOUT.read)

request = client._build_request(FinalRequestOptions(method="get", url="/foo", timeout=httpx2.Timeout(100.0)))
timeout = httpx2.Timeout(**request.extensions["timeout"]) # type: ignore
Expand Down Expand Up @@ -1497,6 +1498,7 @@ async def test_request_timeout(self, async_client: AsyncAnthropic) -> None:
request = async_client._build_request(FinalRequestOptions(method="get", url="/foo"))
timeout = httpx2.Timeout(**request.extensions["timeout"]) # type: ignore
assert timeout == DEFAULT_TIMEOUT
assert request.headers["x-stainless-timeout"] == str(DEFAULT_TIMEOUT.read)

request = async_client._build_request(
FinalRequestOptions(method="get", url="/foo", timeout=httpx2.Timeout(100.0))
Expand Down