Add tablet workspace layout by klopez4212 · Pull Request #4274 · block/buzz

klopez4212 · 2026-08-02T07:40:36Z

Summary

Add a desktop-like tablet workspace for iPad and Android tablets, with persistent navigation and Inbox detail panes.
Align tablet-only surfaces, onboarding, settings, and camera layouts with the desktop visual language.
Fix thread reactions and wait for hydrated thread data before opening Inbox deep links.

Tablet view

Validation

bin/just mobile-check
bin/just mobile-test

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-02T07:41:25Z

🤖 Tablet workspace snapshot

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e0d7e628ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

…ator Signed-off-by: kenny lopez <klopez4212@gmail.com>

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f552a95cc3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21abc530cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64a589bd7e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b59dc05f23

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ator Signed-off-by: kenny lopez <klopez4212@gmail.com> # Conflicts: # mobile/lib/features/activity/activity_page.dart # mobile/test/features/activity/activity_page_test.dart

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8508c11c98

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6dd0f5105

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ea7367d65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-03T17:00:28Z

🤖 @codex review

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-03T17:09:28Z

🤖 @codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ca134fac1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-03T17:17:36Z

🤖 @codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 737d3d1aef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

…ator Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-03T17:30:11Z

🤖 @codex review

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-03T17:35:11Z

🤖 @codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c78d6cdf50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-03T17:43:57Z

🤖 @codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 621ce0e009

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-03T17:54:59Z

🤖 @codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be7933d272

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 · 2026-08-03T18:12:50Z

🤖 @codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2003db3b60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-03T18:18:18Z

 import '../../shared/widgets/mobile_tab_footer_backdrop.dart';
+import '../../shared/widgets/skeleton.dart';
 import '../activity/activity_page.dart';
+import '../activity/activity_provider.dart';


Move Activity settlement out of the Home feature

Fresh evidence after the earlier Home-boundary fix is this newly added direct import from features/home into the sibling Activity implementation solely to inspect activityProvider. This recreates the prohibited cross-feature dependency and couples the workspace shell to Activity's provider lifecycle; expose the settlement signal through shared/ or a callback/public coordinator instead.

AGENTS.md reference: AGENTS.md:L551-L552

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-03T18:18:18Z

+    final navigatorKey = useMemoized(GlobalKey<NavigatorState>.new, [
+      item!.conversationId,
+    ]);


Refresh the detail route when the selected row is tapped

When a grouped conversation is already selected and a newer unread event changes its deep-link target, tapping that row updates selectedItemTarget but leaves this navigator keyed only by the unchanged conversationId. The existing initial route is therefore retained and ChannelDetailPage never receives the new initialMessageId, so the tap does not open the represented unread message as documented. Explicitly navigate the current nested stack or include a tap-generation key while preserving the stable key for passive feed updates.

Useful? React with 👍 / 👎.

jedwards27

A Team review — source-clear at exact head; rebase required

Reviewed exact head 2003db3b60192623176cbaa6260df04e90d66003.

I found no concrete PR-owned defect after reconciling the two suspected Activity lifecycle failures against the final source:

A left channel is removed from suppression on a non-member → member transition (mobile/lib/features/activity/activity_page.dart:109-122), so same-session rejoin is handled.
Changing the Activity category filter explicitly clears selected/retained detail (activity_page.dart:398-403); the focused Reminders regression covers that transition (mobile/test/features/activity/activity_page_test.dart:319-357). The retention at activity_page.dart:142-162 is limited to the intentional unread-only read transition.

Historical exact-head CI, including Mobile, is green, and git diff --check 6de85fe31d781122756aecf954bae7d357a56b9a..2003db3b60192623176cbaa6260df04e90d66003 passes in a clean detached worktree.

This is not an approval to merge: GitHub currently reports DIRTY / CONFLICTING with main, so no current merge result exists. Resolve the conflicts, then rerun the affected mobile package gates and the tablet community-switch, Activity filter/retention, leave/rejoin, split-view navigation, and camera-layout journeys. Any new head requires delta review.

jedwards27

A Team final synthesis — changes requested

A Team re-review at exact head 2003db3b60192623176cbaa6260df04e90d66003 found the frozen source/test state clear, but the branch cannot be integrated: fresh current main has no merge base with this head (git merge-base exits 1; git merge-tree --write-tree refuses unrelated histories), and GitHub reports DIRTY / CONFLICTING.

Exact-head evidence is strong: full Mobile passed 1,110 / 1 skipped, mobile-check passed when correctly anchored to historical base 6de85fe31d781122756aecf954bae7d357a56b9a, historical exact-head CI is green, and the suspected filter/rejoin source defects do not hold. There is still no focused leave→rejoin Activity regression and no native iPad split-view/orientation/community-switch/camera/accessibility journey.

Rebase/rebuild onto current main, then treat the resulting SHA as new: delta review, full affected mobile gates, Android/iOS builds, and native tablet/community/filter/leave→rejoin/camera/accessibility proof. The prior COMMENTED review 4948261420 was premature; this A Team verdict supersedes it.

wesbillman

Carl automated review: changes requested

Carl, an automated reviewer, commenting via Wes’s GitHub account.

Reviewed exact head 2003db3b60192623176cbaa6260df04e90d66003 against base bbd20fae75ecc3bd7a83cc12a65379fac22a2b79.

P2 — Landscape phones enter the tablet workspace (mobile/lib/features/home/home_page.dart:37,60-64). The layout predicate checks only width >= 840. A large handset rotated to landscape, such as a 932×430 logical-pixel viewport, therefore loses the phone tab bar and mounts the 280px tablet sidebar and inset canvas. Gate this layout on the tablet/window-size contract rather than width alone, and cover a wide-but-short handset viewport.
P2 — Retapping the selected grouped Inbox row does not navigate to its newly represented unread event (mobile/lib/features/activity/activity_page.dart:215-245,482-519). openItem computes and stores the new exact target, but _WideActivityDetail preserves its nested Navigator solely by conversationId; rebuilding does not regenerate the existing initial route. Reproduce by selecting a grouped conversation, receiving/exposing another unread target in the same group, then retapping the row: the detail remains on the old message. Drive the nested navigator to the new target (or use an explicit user-tap generation) and add an exact message/thread-root regression.

GitHub also still reports this head as DIRTY / CONFLICTING, so it has no current integration result. Historical exact-head CI is green, but it does not exercise either transition above. Resolve the defects and conflicts on a new head, then rerun the affected mobile gates and responsive navigation journeys.

rclod · 2026-09-16T02:13:50Z

Thank you @klopez4212 for establishing the tablet workspace direction here. Because this branch now has unrelated history, conflicts with current main, and maintainer edits are disabled, I rebuilt the focused current-main version in #7675. It preserves the persistent tablet workspace and addresses the outstanding landscape-phone and grouped-Inbox review findings. Your original design and implementation work are credited in the replacement PR.

Add tablet workspace layout

a307669

Signed-off-by: kenny lopez <klopez4212@gmail.com>

klopez4212 added a commit that referenced this pull request Aug 2, 2026

screenshots: PR #4274

61896ea

klopez4212 added 4 commits August 2, 2026 09:30

Preserve tablet camera aspect ratio

4b98651

Signed-off-by: kenny lopez <klopez4212@gmail.com>

Restore filled tablet camera preview

e0e4b7f

Signed-off-by: kenny lopez <klopez4212@gmail.com>

Match tablet camera surface to mobile

94b052f

Signed-off-by: kenny lopez <klopez4212@gmail.com>

Match tablet camera to preview ratio

e0d7e62

Signed-off-by: kenny lopez <klopez4212@gmail.com>

bossriceshark mentioned this pull request Aug 2, 2026

fix(mobile): open threads pinned to the newest reply #4355

Open

klopez4212 marked this pull request as ready for review August 3, 2026 12:20

klopez4212 requested a review from a team as a code owner August 3, 2026 12:20

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/home/home_page.dart Outdated

Comment thread mobile/lib/features/activity/activity_page.dart

Comment thread mobile/lib/features/home/home_page.dart Outdated

klopez4212 added 3 commits August 3, 2026 13:37

fix tablet workspace review findings

09d1e24

Signed-off-by: kenny lopez <klopez4212@gmail.com>

Merge remote-tracking branch 'origin/main' into kennylopez-ipad-simul…

ed1c380

…ator Signed-off-by: kenny lopez <klopez4212@gmail.com>

fix desktop catalog test formatting

f552a95

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/home/home_page/wide_navigation.dart Outdated

Comment thread mobile/lib/features/channels/channel_management_provider.dart

fix tablet navigation and reaction rollback

21abc53

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/home/home_page.dart Outdated

keep stale channels hidden during relay switch

64a589b

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/ios/Runner.xcodeproj/project.pbxproj

Comment thread mobile/lib/features/home/home_page/wide_navigation.dart Outdated

complete ipad orientation and switch recovery

b59dc05

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/channels/channels_page/wide_navigation.dart Outdated

Merge remote-tracking branch 'origin/main' into kennylopez-ipad-simul…

8508c11

…ator Signed-off-by: kenny lopez <klopez4212@gmail.com> # Conflicts: # mobile/lib/features/activity/activity_page.dart # mobile/test/features/activity/activity_page_test.dart

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/channels/thread_detail_page.dart Outdated

Comment thread mobile/lib/features/home/home_page/wide_navigation.dart Outdated

Comment thread mobile/lib/features/activity/activity_page.dart Outdated

fix mobile tablet review feedback

b6dd0f5

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/channels/channels_provider.dart

Comment thread mobile/lib/features/activity/activity_page.dart

klopez4212 added 2 commits August 3, 2026 17:06

isolate home workspace navigation

11a4837

Signed-off-by: kenny lopez <klopez4212@gmail.com>

fix mobile switch and inbox selection

2ea7367

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

klopez4212 added 2 commits August 3, 2026 17:20

fix tablet inbox review feedback

9974e9b

Signed-off-by: kenny lopez <klopez4212@gmail.com>

split tablet channel content

53d3220

Signed-off-by: kenny lopez <klopez4212@gmail.com>

address mobile review feedback

7ca134f

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/channels/channels_page.dart Outdated

Comment thread mobile/lib/features/activity/activity_page.dart

Comment thread mobile/lib/features/activity/activity_page.dart Outdated

fix tablet inbox review findings

737d3d1

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/activity/activity_page.dart

klopez4212 added 2 commits August 3, 2026 18:24

fix mobile status provider layering

97294b4

Signed-off-by: kenny lopez <klopez4212@gmail.com>

Merge remote-tracking branch 'origin/main' into kennylopez-ipad-simul…

750cf74

…ator Signed-off-by: kenny lopez <klopez4212@gmail.com>

fix wide inbox channel leave handling

c78d6cd

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/activity/activity_page.dart

fix retained activity detail filtering

621ce0e

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/channels/channels_page/wide_navigation.dart Outdated

fix tablet community switch activity loading

be7933d

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread mobile/lib/features/channels/channels_page/wide_navigation.dart

Comment thread mobile/lib/features/activity/activity_page.dart

fix tablet switch recovery and inbox rejoin

2003db3

Signed-off-by: kenny lopez <klopez4212@gmail.com>

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Realcryptoplato mentioned this pull request Aug 9, 2026

Epic: production-hosted multi-device Buzz Web Realcryptoplato/buzz-web#2

Open

15 tasks

jedwards27 reviewed Aug 17, 2026

View reviewed changes

jedwards27 requested changes Aug 17, 2026

View reviewed changes

kaalph pushed a commit to kaalph/buzz that referenced this pull request Aug 21, 2026

screenshots: PR block#4274

a94e93f

wesbillman requested changes Aug 27, 2026

View reviewed changes

fdagostino mentioned this pull request Sep 8, 2026

fix(mobile): offer retry when the initial connection stalls #7486

Closed

rclod mentioned this pull request Sep 16, 2026

feat(mobile): add adaptive tablet workspace #7675

Open

Uh oh!

Conversation

klopez4212 commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tablet view

Validation

Uh oh!

klopez4212 commented Aug 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

klopez4212 commented Aug 3, 2026

Uh oh!

klopez4212 commented Aug 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

klopez4212 commented Aug 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

klopez4212 commented Aug 3, 2026

Uh oh!

klopez4212 commented Aug 2, 2026 •

edited

Loading