Conversation
Signed-off-by: rclod <3385524+rclod@users.noreply.github.com>
🔐 Codex Security Review
|
Signed-off-by: rclod <3385524+rclod@users.noreply.github.com>
Signed-off-by: rclod <3385524+rclod@users.noreply.github.com>
…workspace Signed-off-by: rclod <3385524+rclod@users.noreply.github.com>
The tablet workspace part file references ThreadDetailPage, but home_page.dart only imported thread_detail_target.dart, so the branch failed to compile. The new pane test also used a const constructor with a non-const channel fixture. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: rclod <3385524+rclod@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Buzz now fills iPad windows and uses a persistent tablet workspace when the available window is both wide and tall enough. Channels and DMs stay visible beside Activity, Search, and the selected detail, while narrow Split View windows and wide landscape phones keep the existing compact navigation.
Physical-device testing found three follow-up gaps that are now covered: rotating an open phone-style channel into landscape hands it back to the persistent workspace, opening a thread uses a third pane instead of replacing the channel, and the detail surface meets the iPad screen edges without desktop-window corner rounding. Every thread entry point uses the same pane-aware navigation path, including message taps, reply actions, media replies, nested threads, and deep links.
The window contract checks the shortest side as well as width, so a 932×430 phone cannot be mistaken for a tablet. Split Activity navigation also treats every explicit row tap as a new target, which lets a grouped conversation reopen at a newly unread message without replacing the persistent Inbox list.
This is a current-
mainrebuild of the layout direction started by @klopez4212 in #4274. That branch no longer has a mergeable history and does not allow maintainer edits; this PR keeps the focused tablet workspace and the review regressions rather than carrying its unrelated changes forward.Related issue
Fixes #7454.
Replaces #4274, with credit to its original author and design work.
Testing
flutter analyze --no-pubflutter test --no-pub --dart-define=BUZZ_PUSH_GATEWAY_URL=https://push.example— 2,239 passed, 4 skipped on the original tablet-workspace headInfo.plistparsed successfully; Debug, Profile, and Release all target device families1,2Native iPad simulator execution is not available on this Linux/arm64 host. The follow-up layout was validated from physical-device screenshots; the updated build still needs one OTA confirmation on the iPad for rotation and thread-pane interaction.
Before
After