Skip to content

Add Verity quality gate and project memory - #2753

Open
claudiacodacy wants to merge 1 commit into
masterfrom
verity-setup
Open

claudiacodacy wants to merge 1 commit into
masterfrom
verity-setup

Conversation

@claudiacodacy

Copy link
Copy Markdown
Contributor

Introduces Verity to this repo: a shared quality standard, a committed knowledge graph, and the agent-facing instructions that make both load-bearing.

What's here

Path Purpose
.verity/standard.yaml The shared quality standard
.verity/memory/ Knowledge graph — 17 nodes + index + schema
.claude/skills/verity-* 8 skills: analyze, feedback, insights, learn, memory, reflect, setup, status
.claude/settings.json Hooks wiring the gate into the session lifecycle
CLAUDE.md Project memory, waiver rules, post-task reflection, housekeeping turns
.gitignore Ignores machine-local .verity/ state

Notes

  • The knowledge graph is deliberately committed, not machine-local — the .gitignore rule ignores .verity/* but re-includes standard.yaml and memory/ (minus memory/log.md), so the guidance is shared across contributors rather than living on one laptop.
  • The CLAUDE.md additions sit inside verity-memory markers and are tool-owned/regenerated, except the preserve region which is for hand-curated guidance.
  • The waiver rules are intentionally strict: verity waive is only for relaying a risk a human explicitly accepted, never agent judgment.

🤖 Generated with Claude Code

Introduces Verity to this repo: a standard, a knowledge graph, and the
agent-facing instructions that make both load-bearing.

- `.verity/standard.yaml` — the shared quality standard
- `.verity/memory/` — knowledge graph (17 nodes + index + schema), committed
  so the guidance is shared rather than machine-local
- `.claude/skills/verity-*` — 8 skills (analyze, feedback, insights, learn,
  memory, reflect, setup, status)
- `.claude/settings.json` — hooks wiring the gate into the session lifecycle
- `CLAUDE.md` — project memory, accepted-risk waiver rules, post-task
  reflection, and housekeeping-turn declarations
- `.gitignore` — ignores machine-local `.verity/` state, keeping the standard
  and knowledge graph tracked

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@claudiacodacy
claudiacodacy requested a review from a team as a code owner September 17, 2026 10:31
@codacy-production

codacy-production Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The committed memory graph is not discoverable because its index states that no nodes exist, and one memory node is truncated. The Standard also enables ESLint while referencing configuration files that are absent from the repository, leaving the declared quality gate non-runnable in a fresh checkout.

The overall Codacy analysis is not up to standards because coverage requirements are missing, although the quality issue analysis itself reports no additional issues. Required validation and integration tests are missing, including pattern validation, lifecycle hooks, gitignore behavior, memory integrity, and setup generation.

About this PR

  • Add automated integration coverage for setup, lifecycle hooks, and validator behavior; also verify the documented commands work from a fresh checkout with the expected Verity CLI installation assumptions.

Test suggestions

  • Validate configured Codacy pattern IDs, including valid, invalid, missing-adapter, malformed-config, and empty-pattern cases.
  • Exercise --list and --emit pattern discovery, filtering, invalid-regex handling, and complete stdout delivery through a pipe.
  • Verify Claude settings contain and execute the intended lifecycle hooks and commands.
  • Verify .gitignore tracks .verity/standard.yaml and memory nodes while ignoring local state and memory/log.md.
  • Validate the committed memory graph against the documented schema and ensure the index reflects committed nodes.
  • Verify setup instructions generate a Standard, Codacy configuration, Verity-owned ESLint configuration, and VERITY.md for the detected project.
  • Verify waiver guidance requires human-approved rationale and describes file-byte invalidation behavior.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Validate configured Codacy pattern IDs, including valid, invalid, missing-adapter, malformed-config, and empty-pattern cases.
2. Exercise `--list` and `--emit` pattern discovery, filtering, invalid-regex handling, and complete stdout delivery through a pipe.
3. Verify Claude settings contain and execute the intended lifecycle hooks and commands.
4. Verify `.gitignore` tracks `.verity/standard.yaml` and memory nodes while ignoring local state and `memory/log.md`.
5. Validate the committed memory graph against the documented schema and ensure the index reflects committed nodes.
6. Verify setup instructions generate a Standard, Codacy configuration, Verity-owned ESLint configuration, and VERITY.md for the detected project.
7. Verify waiver guidance requires human-approved rationale and describes file-byte invalidation behavior.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Comment thread .verity/standard.yaml
Comment thread .verity/memory/domain/n009-hard-rules.md
Comment thread .verity/memory/index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants