Add Verity quality gate and project memory - #2753
claudiacodacy wants to merge 1 commit into
Conversation
Introduces Verity to this repo: a standard, a knowledge graph, and the agent-facing instructions that make both load-bearing. - `.verity/standard.yaml` — the shared quality standard - `.verity/memory/` — knowledge graph (17 nodes + index + schema), committed so the guidance is shared rather than machine-local - `.claude/skills/verity-*` — 8 skills (analyze, feedback, insights, learn, memory, reflect, setup, status) - `.claude/settings.json` — hooks wiring the gate into the session lifecycle - `CLAUDE.md` — project memory, accepted-risk waiver rules, post-task reflection, and housekeeping-turn declarations - `.gitignore` — ignores machine-local `.verity/` state, keeping the standard and knowledge graph tracked Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
The committed memory graph is not discoverable because its index states that no nodes exist, and one memory node is truncated. The Standard also enables ESLint while referencing configuration files that are absent from the repository, leaving the declared quality gate non-runnable in a fresh checkout.
The overall Codacy analysis is not up to standards because coverage requirements are missing, although the quality issue analysis itself reports no additional issues. Required validation and integration tests are missing, including pattern validation, lifecycle hooks, gitignore behavior, memory integrity, and setup generation.
About this PR
- Add automated integration coverage for setup, lifecycle hooks, and validator behavior; also verify the documented commands work from a fresh checkout with the expected Verity CLI installation assumptions.
Test suggestions
- Validate configured Codacy pattern IDs, including valid, invalid, missing-adapter, malformed-config, and empty-pattern cases.
- Exercise
--listand--emitpattern discovery, filtering, invalid-regex handling, and complete stdout delivery through a pipe. - Verify Claude settings contain and execute the intended lifecycle hooks and commands.
- Verify
.gitignoretracks.verity/standard.yamland memory nodes while ignoring local state andmemory/log.md. - Validate the committed memory graph against the documented schema and ensure the index reflects committed nodes.
- Verify setup instructions generate a Standard, Codacy configuration, Verity-owned ESLint configuration, and VERITY.md for the detected project.
- Verify waiver guidance requires human-approved rationale and describes file-byte invalidation behavior.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Validate configured Codacy pattern IDs, including valid, invalid, missing-adapter, malformed-config, and empty-pattern cases.
2. Exercise `--list` and `--emit` pattern discovery, filtering, invalid-regex handling, and complete stdout delivery through a pipe.
3. Verify Claude settings contain and execute the intended lifecycle hooks and commands.
4. Verify `.gitignore` tracks `.verity/standard.yaml` and memory nodes while ignoring local state and `memory/log.md`.
5. Validate the committed memory graph against the documented schema and ensure the index reflects committed nodes.
6. Verify setup instructions generate a Standard, Codacy configuration, Verity-owned ESLint configuration, and VERITY.md for the detected project.
7. Verify waiver guidance requires human-approved rationale and describes file-byte invalidation behavior.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Introduces Verity to this repo: a shared quality standard, a committed knowledge graph, and the agent-facing instructions that make both load-bearing.
What's here
.verity/standard.yaml.verity/memory/.claude/skills/verity-*.claude/settings.jsonCLAUDE.md.gitignore.verity/stateNotes
.gitignorerule ignores.verity/*but re-includesstandard.yamlandmemory/(minusmemory/log.md), so the guidance is shared across contributors rather than living on one laptop.CLAUDE.mdadditions sit insideverity-memorymarkers and are tool-owned/regenerated, except thepreserveregion which is for hand-curated guidance.verity waiveis only for relaying a risk a human explicitly accepted, never agent judgment.🤖 Generated with Claude Code