fix: prevent ValueError when slug is missing with --handle-no-reports-found - #747
Open
sentry[bot] wants to merge 1 commit into
Open
fix: prevent ValueError when slug is missing with --handle-no-reports-found#747sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the CLI would crash with a
ValueError: The provided slug is invalidwhendo-uploadwas called with--handle-no-reports-foundenabled, but no--slugargument was provided.The root cause was that when no coverage reports were found, the
do_upload_logicfunction would attempt to callupload_completion_logicto trigger notifications, passingslug=None. Theencode_slugfunction, called byupload_completion_logic, does not handleNonegracefully and raises aValueError.The fix introduces a check in
do_upload_logicto ensure thatslugis notNonebefore attempting to callupload_completion_logicin the--handle-no-reports-foundfallback path. IfslugisNone, a warning is logged, and the upload completion step is skipped, preventing the crash and providing a more informative output to the user.Fixes CLI-FT