Skip to content

fix: prevent ValueError when slug is missing with --handle-no-reports-found #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent ValueError when slug is missing with --handle-no-reports-found #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions codecov_cli/services/upload/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,16 @@ def do_upload_logic(
upload_data = collector.generate_upload_data(report_type)
except click.ClickException as exp:
if handle_no_reports_found:
if slug is None:
logger.warning(
"No coverage reports found. Cannot trigger upload completion: no slug provided."
)
return RequestResult(
error=None,
warnings=None,
status_code=200,
text="No coverage reports found. Upload completion skipped: no slug provided.",
)
logger.info(
"No coverage reports found. Triggering notifications without uploading."
)
Expand Down
Loading