fix: send coder User-Agent on workspace app icon fetches - #268
Open
ethanndickson wants to merge 2 commits into
Open
fix: send coder User-Agent on workspace app icon fetches#268ethanndickson wants to merge 2 commits into
ethanndickson wants to merge 2 commits into
Conversation
ethanndickson
marked this pull request as ready for review
September 9, 2026 12:50
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
untra
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #264.
Workspace app icons are fetched by
SDWebImagerather thanClient, so they never picked up thecoder-desktop/<version> (darwin/<arch>)User-Agent.SDWebImagesets its own default (Coder Desktop/<version> (Mac OS X ...)) instead, and relative icon URLs resolve to the deployment host, so these requests can be blocked by the same WAF rule.The fix is just to set the header once on
SDWebImageDownloader.sharedat launch, next to where we register the SVG coder. I've made the one-argumentuserAgent(component:)public so the app target can reach it, whilst keeping theversion:/arch:test knobs internal.Icon URLs can be third-party, but the User-Agent carries nothing sensitive, so unlike literal headers it's fine to send it everywhere.