Skip to content

fix: send coder User-Agent on workspace app icon fetches #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ethanndickson merged 2 commits into from
Sep 10, 2026
+7 −5
Merged

fix: send coder User-Agent on workspace app icon fetches #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95e8562
fix: send coder User-Agent on workspace app icon fetches
ethanndickson Sep 9, 2026
6a48bd3
chore: tidy comments
ethanndickson Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import CoderSDK
import FluidMenuBarExtra
import NetworkExtension
import os
Expand Down Expand Up @@ -89,6 +90,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
UserDefaults.standard.setValue(Theme.Animation.tooltipDelay, forKey: "NSInitialToolTipDelay")
// Init SVG loader
SDImageCodersManager.shared.addCoder(SDImageSVGCoder.shared)
SDWebImageDownloader.shared.setValue(CoderSDK.userAgent(component: .app), forHTTPHeaderField: "User-Agent")

menuBar = .init(menuBarExtra: FluidMenuBarExtra(
title: "Coder Desktop",
Expand Down
10 changes: 5 additions & 5 deletions Coder-Desktop/CoderSDK/UserAgent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ enum UserAgentDefaults {
}

/// Formats a `User-Agent` as `<token>/<version> (<goos>/<goarch>)`.
func userAgent(
component: CoderComponent,
version: String = UserAgentDefaults.version,
arch: GoArch = UserAgentDefaults.arch
) -> String {
public func userAgent(component: CoderComponent) -> String {
userAgent(component: component, version: UserAgentDefaults.version, arch: UserAgentDefaults.arch)
}

func userAgent(component: CoderComponent, version: String, arch: GoArch) -> String {
"\(component.rawValue)/\(version) (\(UserAgentDefaults.goos)/\(arch.rawValue))"
}

Expand Down
Loading