🤖 ci: preserve all check-suite failures in the native-stack workflow - #4196
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
The native stack is verified as #4172 → #4173 → #4194 → #4196 (stack #4174). Local Codex code/security reviews are blocked by a checkout-service error: |
|
@codex review Please retry the current published head. Prior attempts failed in the review service with a missing-ref checkout error; no code changes were made since those attempts. Please complete both code and security review. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
f17a305 to
37003ac
Compare
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Code and security review both completed successfully on current head 37003ac, with no findings. The four earlier checkout-error comments all refer to pre-rebase head f17a305 and are now superseded; marking those technical-error comments outdated while retaining the approval and security report. CI's comment gate will be rerun after this cleanup. |
ammar-agent
changed the title
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e661f08c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed PRRT_kwDOPxxmWM6g1iZU: the collector now compares the initial readiness metadata, pins check queries to head/merge OIDs, and re-fetches the complete PR snapshot before returning any results. A changed head, merge OID, merge/review state, or failed final read cannot yield stale success. Added concurrent-update regressions; 22 new gate tests, 12 existing gate tests, shellcheck, static checks, and the live #4194 gate pass. |
|
@codex review |
## Summary Record the user preference to use `gh stack` for GitHub-native stacked PRs, keeping every PR linked in the native stack rather than only chaining base branches. `AGENTS.md` points to `docs/AGENTS.md`; the generated built-in skill copy is synchronized. ## Stack Fourth PR in native stack #4174, directly above #4194: #4172 → #4173 → #4194 → this PR. Stack membership is managed with `gh stack link`. ## Validation - Formatting checked against the resolved `AGENTS.md` target. - `make static-check` and `git diff --check`. - No prose-only assertion tests added. ## Subtractive ledger Production logic: +0 / −0. One documentation line and its generated string mirror; no behavior changes or unrelated subtractions. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$459.97`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=459.97 -->
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 19 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +100 / −49 (net +51), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. Revalidate PR refs and merge/review state before accepting collected checks; a concurrent push or base update returns pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 22 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +125 / −51 (net +74), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
fed5d8f to
46e66aa
Compare
|
@codex review |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
2 participants
Summary
Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated
gh pr checksprojection, and record the preference forgh stackto manage native stacked PRs.Background
On #4194, successful
RequiredandCodex Commentschecks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs.Implementation
BLOCKEDstate. Failure output prioritizes failing checks and identifies their commits.Stack
Only remaining open PR in native stack #4174, now based on main after #4172, #4173, and #4194 merged.
Validation
make static-check, andgit diff --checkpassed.34385271008; retrying that exact run subsequently passed.Risks
Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses.
Production ledger
Workflow scripts/config: +125 / −51 (net +74), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation.
Generated with
xum• Model:openai:gpt-6-astra• Thinking:xhigh• Cost:$591.32