🤖 fix: stabilize local concurrency warning with agent counts - #4194
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
@codex review |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
ammar-agent
added this pull request to stack #4174
September 9, 2026 16:57
Collaborator
Author
|
@codex review Please retry the current published head. Prior attempts failed in the review service with a missing-ref checkout error; no code changes were made since those attempts. Please complete both code and security review. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Make child recovery task-owned, honor existing scoped Stop markers before restart work, and preserve explicit compaction continuations. Remove duplicate startup request precedence and tail classification. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$117.04`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=117.04 -->
Preserve retry opt-outs and pending questions, recognize accepted synthetic guidance after Stop, and contain each pending compaction failure. Strict partial reads distinguish unreadable state from absence without changing existing lenient callers. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$152.14`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=152.14 -->
--- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$222.71`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=222.71 -->
…idance --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$232.99`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=232.99 -->
…dates _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$236.73`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=236.73 -->
_Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$264.85`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=264.85 -->
<!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=264.85 -->
Reuse bulk metadata for identity admission and interrupted retry derivation, retaining the snapshot across deferred reruns. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$316.14`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=316.14 -->
Restore durable parent guidance behind restarted interactive questions without dispatching a turn. Reuse per-ID queue dedupe and settlement; preserve Stop and opt-out precedence. Validation: 1083 targeted regression tests; make static-check. Production ledger: +98/-101, net -3.
Share live/restored guidance background handoff and cancellation settlement. Reuse transient ownership for startup admission, recovery, and empty compaction checks; detach abandoned probes before deferred physical cleanup while preserving adopted sessions. Validation: 1093 tests passed across five lifecycle suites; make static-check passed. Production ledger: +83/-83, net zero.
Distinguish durable Stop/opt-out from indeterminate startup blockers and settle stopped child lifecycles before queued work is admitted. Preserve question waits, read-failure blockers, and live work. Suppress redundant nested handle drains until the complete task-stop batch settles. Simplify stale-starting recovery and reuse the initial queue drain; avoid creating sessions just to clear absent queues. Validation: 1228 tests passed across six lifecycle suites; make static-check passed. Production ledger: +52/-50 (net +2); the lower PR remains neutral against its prior -2 ledger.
Fail closed on preference I/O errors, retry boundedly, and discard rejected load caches without losing owed Stop markers or unknown opt-out state. Cancel only captured durable guidance IDs during stop settlement and contain each startup normalization failure independently. Consolidate preference defaulting and replace manual startup-tail scanning with findLast using identical predicates. Validation: 1810 tests passed across 38 lifecycle/session files, including tail/goal/compaction; make static-check passed. Production ledger: +72/-72, net zero.
Reuse initial shimmer and cached transcript rendering without a spinner lane or permanent padding. Validate stable catch-up geometry and a viewport-fitting initial phone skeleton. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$152.14`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=152.14 -->
Overlay the existing dock edge with accessible shimmer feedback during cached replay, preserving transcript clearance and active-barrier priority. Replace source-syntax viewport assertions with composed metadata and measured phone layout checks. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$21.52`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=21.52 -->
Show a compact tabular count instead of cycling the first active agent name. Preserve family and isolation exclusions, scoped stale-warning clearing, and existing handoff hysteresis. Cover multi-agent handoffs, metadata reordering, and desktop/phone geometry. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$33.18`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=33.18 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Record the user preference to use `gh stack` for GitHub-native stacked PRs, keeping every PR linked in the native stack rather than only chaining base branches. `AGENTS.md` points to `docs/AGENTS.md`; the generated built-in skill copy is synchronized. ## Stack Fourth PR in native stack #4174, directly above #4194: #4172 → #4173 → #4194 → this PR. Stack membership is managed with `gh stack link`. ## Validation - Formatting checked against the resolved `AGENTS.md` target. - `make static-check` and `git diff --check`. - No prose-only assertion tests added. ## Subtractive ledger Production logic: +0 / −0. One documentation line and its generated string mirror; no behavior changes or unrelated subtractions. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$459.97`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=459.97 -->
ammar-agent
force-pushed
the
fix-stable-local-agent-warning
branch
from
September 9, 2026 17:49
c21c9e0 to
99977af
Compare
Collaborator
Author
This comment has been minimized.
This comment has been minimized.
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Collaborator
Author
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
@codex review Retrying the unchanged rebased head after the checkout-service failures. Successful reviews on this stack confirm the published refs are available; please complete code and security review. No source changes or gate bypasses have been made. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Collaborator
Author
|
Both code and security reviews now successfully approve 99977af with no findings. The seven earlier missing-ref checkout errors are superseded and are being marked outdated. No substantive review finding is being hidden; existing approvals and security reports remain visible. |
Collaborator
Author
|
The blocking checks were real: Required and Codex Comments in independent run 34385271008 were hidden by gh pr checks name deduplication behind another successful run. The in-tree readiness fix in #4196 now detects them through GitHub’s complete rollup. Retrying this exact failed run after verifying its underlying review comments are resolved; no merge-queue bypass is involved. |
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 19 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +100 / −49 (net +51), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. Revalidate PR refs and merge/review state before accepting collected checks; a concurrent push or base update returns pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 22 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +125 / −51 (net +74), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Record the user preference to use `gh stack` for GitHub-native stacked PRs, keeping every PR linked in the native stack rather than only chaining base branches. `AGENTS.md` points to `docs/AGENTS.md`; the generated built-in skill copy is synchronized. ## Stack Fourth PR in native stack #4174, directly above #4194: #4172 → #4173 → #4194 → this PR. Stack membership is managed with `gh stack link`. ## Validation - Formatting checked against the resolved `AGENTS.md` target. - `make static-check` and `git diff --check`. - No prose-only assertion tests added. ## Subtractive ledger Production logic: +0 / −0. One documentation line and its generated string mirror; no behavior changes or unrelated subtractions. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$459.97`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=459.97 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 19 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +100 / −49 (net +51), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
ammar-agent
added a commit
that referenced
this pull request
Sep 9, 2026
## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. Revalidate PR refs and merge/review state before accepting collected checks; a concurrent push or base update returns pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Remains directly above #4194 in native stack #4174; #4172 and #4173 have merged. ## Validation - 22 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +125 / −51 (net +74), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
ammario
pushed a commit
that referenced
this pull request
Sep 10, 2026
…4196) ## Summary Make PR readiness use GitHub's complete check rollup instead of the name-deduplicated `gh pr checks` projection, and record the preference for `gh stack` to manage native stacked PRs. ## Background On #4194, successful `Required` and `Codex Comments` checks from one workflow run hid two still-failing checks with the same names in another run. The previous readiness workflow incorrectly reported success. The new discovery path was tested against that live failure and returns exit 1 with both failing job URLs. ## Implementation - Share paginated, commit-pinned head/merge check discovery between the readiness waiter and log extractor; retain independent suite results while relying on GitHub's rollup to exclude superseded attempts. - Fail closed on API errors or incomplete pagination, and keep unknown check states pending. Revalidate PR refs and merge/review state before accepting collected checks; a concurrent push or base update returns pending. - Do not infer that a pending Pixel status explains GitHub's `BLOCKED` state. Failure output prioritizes failing checks and identifies their commits. - Run offline behavioral regressions in CI and update AGENTS.md plus its generated skill copy. ## Stack Only remaining open PR in native stack #4174, now based on main after #4172, #4173, and #4194 merged. ## Validation - 22 new PR-check regressions and 12 existing Codex-gate tests passed. - Shellcheck, `make static-check`, and `git diff --check` passed. - Live reproduction on #4194 surfaced both hidden failures from run `34385271008`; retrying that exact run subsequently passed. ## Risks Readiness becomes intentionally stricter: independent failures and unexplained GitHub blockers can no longer be masked by same-name successes or optional Pixel statuses. ## Production ledger Workflow scripts/config: +125 / −51 (net +74), excluding tests and documentation. Removed repeated state predicates, duplicated discovery, and the unsafe Pixel/BLOCKED shortcut; added complete paginated discovery and validation. --- _Generated with `xum` • Model: `openai:gpt-6-astra` • Thinking: `xhigh` • Cost: `$591.32`_ <!-- mux-attribution: model=openai:gpt-6-astra thinking=xhigh costs=591.32 -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Third PR, stacked on #4173 (
fix-chat-loading-gap), which is stacked on #4172. Merge bottom-up; this diff contains only the concurrency-warning change.Summary
Replace changing agent names with a stable compact count: “N other local agents running — may interfere.” Agent activity handoffs previously switched the selected name and caused random-looking flashes. Names no longer participate in warning rendering.
Implementation
Validation
make static-checkpasses on the integrated three-PR stack.Subtractive ledger
P1: 27 production lines added, 33 removed; net −6. Removed selected-agent/name resolution and simplified the ChatPane interface. The existing eligibility and handoff safeguards remain. Tests/stories are excluded; no unrelated offsets.
Risks
The warning now reports quantity rather than identity, including for one other agent. Counts change only with activity/eligibility, not with whichever agent happens to appear first.
Generated with
xum• Model:openai:gpt-6-astra• Thinking:xhigh• Cost:$436.55