ENH: test @ and @= operators in matmul tests - #466
Open
haroune-dev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #465.
_test_matmulonly testedmatmul()directly, so neither@nor@=was exercised (a broken__imatmul__passed silently).This resolves the
# TODO: Make this also test the @ operatorand adds@=coverage:@): Error handling for bad shapes, plus output values/dtypes checked againstmatmul().@=): Checked only where the result fitsx1(same shape and dtype) — in-place keepsx1's dtype whilematmul()promotes, and some libs rebind instead of mutating, so values-only check.Tested with
ARRAY_API_TESTS_MODULE=numpy(fulltest_linalg.pypasses) and verified it fails as expected on a broken__imatmul__.