Skip to content

ENH: test @ and @= operators in matmul tests #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haroune-dev wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −1
Open

ENH: test @ and @= operators in matmul tests #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion array_api_tests/test_linalg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ def test_inv(x):
def _test_matmul(namespace, x1, x2):
matmul = namespace.matmul

# TODO: Make this also test the @ operator
if (x1.shape == () or x2.shape == ()
or len(x1.shape) == len(x2.shape) == 1 and x1.shape != x2.shape
or len(x1.shape) == 1 and len(x2.shape) >= 2 and x1.shape[0] != x2.shape[-2]
Expand All @@ -410,6 +409,8 @@ def _test_matmul(namespace, x1, x2):
# libraries will use a custom exception class.
ph.raises(Exception, lambda: xp.matmul(x1, x2),
"matmul did not raise an exception for invalid shapes")
ph.raises(Exception, lambda: x1 @ x2,
"@ did not raise an exception for invalid shapes")
return
else:
res = matmul(x1, x2)
Expand Down Expand Up @@ -437,6 +438,21 @@ def _test_matmul(namespace, x1, x2):
expected=stack_shape + (x1.shape[-2], x2.shape[-1]))
_test_stacks(matmul, x1, x2, res=res)

# Test the @ operator against the matmul() result
res_op = x1 @ x2
ph.assert_dtype("@", in_dtype=[x1.dtype, x2.dtype], out_dtype=res_op.dtype)
assert_equal(res, res_op, "@ gives a different result from matmul()")

# Test @= where the result fits into x1 (same shape and dtype). Only
# values are checked: libraries may implement @= as rebinding
# (x1 = x1 @ x2) rather than true in-place mutation (numpy itself
# does not define __imatmul__), and in-place mutation keeps x1's
# dtype while matmul() promotes (e.g. uint8 @= uint16 stays uint8).
if res.shape == x1.shape and res.dtype == x1.dtype:
x1_inplace = xp.asarray(x1, copy=True)
x1_inplace @= x2
assert_equal(res, x1_inplace, "@= gives a different result from matmul()")

@pytest.mark.unvectorized
@pytest.mark.xp_extension('linalg')
@given(
Expand Down
Loading