Conversation
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Driver environment
DriverEnvironmentDetector.build()into the telemetry config .DriverEnvironmentBuilder->DriverEnvironmentDetector; reportDRIVER_NAMEasGoogle-BigQuery-JDBC-Driver.RuntimeExceptionwhile persisting thetelemetry tag, not just
SecurityException.SQLState emission
BigQueryJdbcSqlStates(11 SQL:2003 constants) andBigQueryJdbcExceptionUtils.sqlStateForCause(), mapping BigQueryreasonvalues onto standard states with an
HY000default.BigQueryJdbcExceptionconstructors now set a SQLState; theInterruptedExceptionoverload reports57014.BigQueryConversionException->22000, feature-not-supported ->0A000,syntax error ->
42000.BigQueryJdbcSqlSyntaxErrorException(BigQueryException), which passed"Incorrect SQL syntax."into the SQLState parameter and dropped the cause.BigQueryJdbcCoercionExceptionandBigQueryJdbcCoercionNotFoundException.Error metrics
TelemetryManager.extractXdbcCode(): first numeric SQLState in the causechain,
0when none.BigQueryJdbcContextProxyat theInvocationTargetExceptionboundary, before
throw cause, leaving the exception unchanged.Batching
batchSizeThreshold, dispatched to the batcher threadso no caller thread does network I/O.
2 x batchSizeThreshold(fallback 3000),preserving
threshold < cap.reschedule()continuesto space retries.