Close UTC-Time P0 display precision gaps - #56
Closed
masarray wants to merge 5 commits into
Closed
Conversation
This was referenced Aug 13, 2026
masarray
added a commit
that referenced
this pull request
Aug 14, 2026
Owner
Author
|
Superseded by the current-main consolidation PR #73, merged as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Iec61850UtcTimeFormatterpolicy for IEC 61850 UTC-Time display;fffffff);fffff) for event/dispute analysis without changing the decoded timestamp;MmsDataCodecand the sharedMmsDataValueRendererthrough the full-precision formatter;TimeOfEntrypath that could still fall back to.fffafter PR Preserve IEC 61850 UTC-Time sub-millisecond precision #55;0x335A86/31.2006000case, structured values, report headerTimeOfEntry, and the five-digit engineering view;Root cause
PR #55 fixed the wire decode and primary timestamp binding path, but
MmsDataValueRenderer.FormatScalarstill formatted UTC-Time withyyyy-MM-dd HH:mm:ss.fff. Structured MMS values and reportTimeOfEntryuse that renderer, so sub-millisecond evidence could still be truncated to milliseconds even though the underlying decoded timestamp was preserved.Engineering impact
A source timestamp such as
...36.2006000remains available at full engine precision and can also be presented as...36.20060in an engineering view. This makes the difference between truncation (36.200) and millisecond rounding (36.201) visible during FAT, SOE/event analysis, and vendor disputes.Validation
Deterministic tests added for:
TimeOfEntryfull precision;Local CLI validation could not be run in this ChatGPT environment because outbound GitHub access and
ghare unavailable; GitHub Actions CI is the validation gate for this draft PR.Remaining scope
This P0 intentionally does not add raw 8-byte UTC-Time provenance to
MmsDataValue; preserving wire bytes is the separate forensic P1 follow-up.