Preserve full UTC-Time precision and wire provenance - #73
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45fef1268c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| public string Summary => | ||
| $"IED timestamps={IedTimestamps.Count}; TimeOfEntry={(string.IsNullOrWhiteSpace(ReportTimeOfEntryDisplay) ? "-" : ReportTimeOfEntryDisplay)}; ReceivedAt={ReceivedAtUtc}"; | ||
|
|
||
| public static MmsReportTimestampEvidence FromFrame(MmsReportFrame frame, MmsInformationReport? decodedReport = null) |
There was a problem hiding this comment.
For frames returned by either live reporting path, callers cannot provide decodedReport: TryAppendInformationReport discards it after mapping (MmsReportLiveSession.cs:1591-1592), and the persistent monitor does the same (MmsPersistentReportMonitor.cs:600-601). Consequently the default call FromFrame(frame) always returns empty ReportTimeOfEntry evidence, even when the received UTC-Time has preserved wire bytes. Carry the typed TimeOfEntry value/evidence through MmsReportFrame or populate the evidence while mapping.
Useful? React with 👍 / 👎.
| public string FullPrecisionLocal { get; init; } = string.Empty; | ||
| public string EngineeringLocal { get; init; } = string.Empty; | ||
|
|
||
| public bool ClockSynchronized => !ClockFailure && !ClockNotSynchronized; |
There was a problem hiding this comment.
When Decode cannot find a UTC-Time, it returns the default evidence object with IsDecoded == false, but this computed property still evaluates to true because both failure flags default to false. Any consumer inspecting the typed field rather than Summary will therefore report unavailable evidence as a synchronized clock; make synchronization nullable or gate it on IsDecoded.
AGENTS.md reference: AGENTS.md:L88-L90
Useful? React with 👍 / 👎.
1 participant
Current-main consolidation of stale draft PRs #56 and #57.
This port is based on ARIEC
main6ac47500cd094b13e2e8b306bf0544c7d92cb874and applies the old work selectively rather than merging the diverged branches..fff;TimeOfEntry, and clientReceivedAtevidence;TimeOfEntryevidence on an exact decoded-report display match;If this current-main port passes full CI and merges, #56/#57 will be closed as superseded rather than merged directly.