fix(build): restore javadoc jar contents - #1979
Merged
Yury Semikhatsky (yury-s) merged 2 commits intoSep 14, 2026
Merged
Conversation
Since the Automatic-Module-Name manifest entries were added (microsoft#1947), maven-javadoc-plugin runs javadoc in module mode with a broken --patch-module path and the playwright javadoc jar ends up empty. Use legacy (classpath) mode.
The empty javadoc jar comes from the plugin computing the --patch-module path as null when subpackages is set without an explicit sourcepath. Setting sourcepath keeps the classic javadoc layout without disabling module path support globally.
Yury Semikhatsky (yury-s)
requested review from
Devin Rousso (dcrousso) and
Pavel Feldman (pavelfeldman)
September 14, 2026 18:15
Pavel Feldman (pavelfeldman)
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automatic-Module-Name,maven-javadoc-pluginruns javadoc in module mode and, becausesubpackagesis set withoutsourcepath, passes--patch-module com.microsoft.playwright=null. Theplaywrightjavadoc jar ends up empty (4 files instead of ~850);failOnError=falsehides the error.sourcepathexplicitly, which restores the pre-feat: add Automatic-Module-Name manifest entries #1947 javadoc output and layout.