test: start a new fixture server when a test class is rerun - #1985
Merged
Yury Semikhatsky (yury-s) merged 1 commit intoSep 14, 2026
Merged
Conversation
ServerLifecycle stopped the server in afterAll but kept it in serverMap, so surefire reruns (PW_MAX_RETRIES) got the stopped server and failed with net::ERR_CONNECTION_REFUSED instead of retrying the test. Also make the map concurrent since test classes run in parallel.
Pavel Feldman (pavelfeldman)
approved these changes
Sep 14, 2026
Yury Semikhatsky (yury-s)
merged commit Sep 14, 2026
f4eacb0
into
microsoft:main
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerLifecyclestopped the server inafterAllbut kept it inserverMap, so surefire reruns (PW_MAX_RETRIES) reused the stopped server and failed withnet::ERR_CONNECTION_REFUSED(e.g.TestBrowserContextClearCookieson webkit in chore: mark 1.63.0 #1983). Remove it from the map on stop.ConcurrentHashMapsince test classes run in parallel.