Skip to content

test: start a new fixture server when a test class is rerun #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yury Semikhatsky (yury-s) merged 1 commit into from
Sep 14, 2026
+5 −3
Merged

test: start a new fixture server when a test class is rerun #1985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions playwright/src/test/java/com/microsoft/playwright/junit/ServerLifecycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
import org.junit.jupiter.api.extension.*;

import java.io.IOException;
import java.util.HashMap;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;

import static com.microsoft.playwright.Utils.nextFreePort;

Expand All @@ -31,7 +31,8 @@ public class ServerLifecycle implements BeforeAllCallback, AfterAllCallback, Par
public static Map<Class<?>, Server> serverMap;

static {
serverMap = new HashMap<>();
// Test classes run concurrently.
serverMap = new ConcurrentHashMap<>();
}

@Override
Expand All @@ -41,7 +42,8 @@ public void beforeAll(ExtensionContext extensionContext) throws Exception {

@Override
public void afterAll(ExtensionContext extensionContext) {
Server server = serverMap.get(extensionContext.getRequiredTestClass());
// Remove the stopped server so that a rerun of the class (e.g. surefire's rerunFailingTestsCount) starts a new one.
Server server = serverMap.remove(extensionContext.getRequiredTestClass());
if (server != null) {
server.stop();
}
Expand Down
Loading