Retry session-state test cleanup on Windows - #14756
Merged
Sean McManus (sean-mcmanus) merged 2 commits intoSep 9, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Sean McManus (sean-mcmanus)
September 9, 2026 14:05
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused retry configuration directly addresses the confirmed transient Windows EBUSY cleanup failure.
Pull request overview
Adds resilient Windows cleanup for the session-state integration test.
Changes:
- Retries transient filesystem-lock failures for up to 5.5 seconds.
- Preserves immediate cleanup and persistent-error reporting.
File summaries
| File | Description |
|---|---|
Extension/test/scenarios/SingleRootProject/tests/buildAndDebug.test.ts |
Adds retry options to temporary-directory removal. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sean McManus (sean-mcmanus)
marked this pull request as ready for review
September 9, 2026 14:22
Colen Garoutte-Carson (Colengms)
approved these changes
Sep 9, 2026
…tate-test-cleanup
Sean McManus (sean-mcmanus)
enabled auto-merge (squash)
September 9, 2026 19:01
Sean McManus (sean-mcmanus)
deleted the
seanmcm/devbox2-wsl/agent150/retry-session-state-test-cleanup
branch
September 9, 2026 19:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry removal of the temporary directory used by the active-document language-change session-state test when Windows briefly reports a filesystem lock after the editor closes.
maxRetries: 10andretryDelay: 100on the existing recursivefs.promises.rmcall. Linear backoff allows up to 5.5 seconds of retry delays, with no added delay when deletion succeeds immediately.Validation
EBUSY; the edited cleanup succeeds after the lock is released.EBUSY, retry exhaustion for persistentEBUSY, and propagation of unrelatedEACCESerrors, with the original cleanup as a negative control.