feat: complete typed Market Data coverage - #99
Open
nyg wants to merge 3 commits into
Open
Conversation
Move new API documentation into the README, preserve existing comments, and apply the no-comments rule to all added code. Rewrite endpoint and facade tests with MockitoExtension, AssertJ, explicit types, unit variables, and self-contained should/when methods. Verified with Temurin 25 and mvnd: both modules package successfully, all 60 tests pass, and the Javadoc artifact builds.
Document client-facing types, constructors, methods, parameters, response records, and enums in the existing library style. Keep implementation helpers and tests free of new comments.
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the Market Data sub-task of #82 by adding typed support for
OHLC,Depth,Trades,Spread,GroupedBook, and authenticatedLevel3.Kraken's current Spot REST specification also includes
MaintenanceSchedule, which was absent from the issue's August inventory. This PR adds that endpoint and its public enum constant too, bringing Market Data to 12/12 endpoints with typed methods.KrakenAPIconvenience methods. SupportassetVersionandasset_classwhere documented.MarketDataExample, and update the custom-endpoint example to use an accurate order-book response shape. Client-facing library types and methods include Javadoc consistent with the existing API; implementation helpers and tests have no added comments.Validation:
JAVA_HOME=/Library/Java/JavaVirtualMachines/temurin-25.jdk/Contents/Home ~/.local/bin/mvnd -B clean packagepasses for both modules (60 tests, no failures). Library Javadoc passes withdoclint=all,-missing. Tests use documented JSON fixtures and Mockito requester mocks; no live authenticated Kraken request was made.Refs #82. The umbrella issue remains open for the other API groups.