[Configuration] Skip deprecated rules from active set, warn only instead of crashing - #8358
Merged
Merged
Conversation
…ot crash with exit code 1
TomasVotruba
force-pushed
the
fix-deprecated-rules-exit-code
branch
from
August 22, 2026 11:01
6852d14 to
f951c9a
Compare
TomasVotruba
enabled auto-merge (squash)
August 22, 2026 11:01
This was referenced Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9859
A registered deprecated rule crashed Rector with exit code 1 instead of only warning.
DeprecatedRulesReporterprinted the deprecation as a warning, but the rule was still registered and run. Every deprecated rule has a guttedrefactor()that throws, so as soon as it matched a node the run crashed.Fix:
ConfigurationRuleFilternow drops deprecated rules from the active set. They still warn, but never run.Before: warning +
[ERROR]-> exit code 1After: warning only -> exit code 0