Escape subscription serializer magic keys - #5722
Open
ydah wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphQL::Subscriptions::Serializeuses single-key Hashes with reserved keys to represent values such as Global IDs, symbols, timestamps, and OpenStructs.Currently, user-provided Hashes containing those keys are serialized without escaping:
Likewise, a Hash containing
__ostruct__is loaded as an OpenStruct instead of being returned as the original Hash. Collisions with__sym__,__sym_keys__, and__timestamp__can also change or reject user data.This can affect subscription arguments and scopes containing client-controlled JSON values.
This PR wraps Hashes whose keys collide with serializer metadata in a dedicated Hash representation using serialized key-value pairs. The wrapper key itself is also escaped recursively.
Hashes without reserved keys keep their existing serialized format, and existing GlobalID, Symbol, timestamp, and OpenStruct payloads continue to deserialize as before.