Define configured theme palette overrides - #12
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Hosts need reusable organization-specific palettes without putting visual values in Stack source or introducing a separate theme-selection flag. A user-defined
defaultmust be able to replace the installed default intentionally while remaining non-recursive.Implementation Approach
extendsfrom the installed builtin catalog before applying overrides.default,light, anddark.STK6001fallback behavior through the effective configured default.Testing Approach
check-jsonschema 0.38.0.stack-sh/compilerconformance tests against this specification checkout.Review Perspectives / Points of Concern
default: { extends: default }unambiguously means builtin-base resolution followed by configured override registration.