Skip to content

fix(acs-ci): bound GCS preflight request - #211

Merged
robbycochran merged 1 commit into
mainfrom
codex/acs-preflight-bounded
Sep 17, 2026
Merged

robbycochran merged 1 commit into
mainfrom
codex/acs-preflight-bounded

Conversation

@robbycochran

@robbycochran robbycochran commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Use gsutil bucket metadata for the ACS preflight instead of enumerating the entire logs prefix. This keeps the connectivity check bounded while still exercising the sandbox CA bundle and GCS provider.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the nightly preflight check to verify that the configured storage bucket exists directly, improving validation accuracy.

@stackrox-openshell-workflow stackrox-openshell-workflow Bot added the stackrox-ai-review Opt in to StackRox AI review label Sep 17, 2026
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6221e4fc-e171-4cc1-9d76-f85ebd2857ba

📥 Commits

Reviewing files that changed from the base of the PR and between d951cac and 73003e7.

📒 Files selected for processing (1)
  • tasks/acs-ci-nightly/workflow/preflight.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review.


Walkthrough

The GCS preflight check now validates bucket existence with gsutil ls -b gs://$GCS_BUCKET instead of listing the logs/ prefix. Pass/fail handling and status propagation remain unchanged.

Changes

GCS preflight validation

Layer / File(s) Summary
Bucket existence check
tasks/acs-ci-nightly/workflow/preflight.yaml
The workflow checks GCS bucket metadata with gsutil ls -b instead of listing the logs/ prefix. Existing pass/fail handling remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 73003

The preflight now validates bucket metadata without enumerating the logs prefix, with no merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: bounding the GCS preflight request in ACS CI.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

echo "GCS: gsutil ls gs://$GCS_BUCKET/logs/"
if /opt/gsutil/bin/gsutil ls "gs://$GCS_BUCKET/logs/" >/dev/null 2>"$gcs_error"; then
echo "GCS: gsutil ls -b gs://$GCS_BUCKET"
if /opt/gsutil/bin/gsutil ls -b "gs://$GCS_BUCKET" >/dev/null 2>"$gcs_error"; then

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check no longer verifies the existence of the logs subdirectory, only the bucket itself. This seems like a weaker preflight check that could allow subsequent steps to fail if they depend on that directory. Is this change intended?

@robbycochran
robbycochran merged commit 5efe5ca into main Sep 17, 2026
13 checks passed
@robbycochran
robbycochran deleted the codex/acs-preflight-bounded branch September 17, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stackrox-ai-review Opt in to StackRox AI review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant