Skip to content

fix(acs-ci): bound GCS preflight request #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robbycochran merged 1 commit into from
Sep 17, 2026
Merged

fix(acs-ci): bound GCS preflight request #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tasks/acs-ci-nightly/workflow/preflight.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ agent:
echo "Jira URL: $JIRA_URL"
echo

echo "GCS: gsutil ls gs://$GCS_BUCKET/logs/"
if /opt/gsutil/bin/gsutil ls "gs://$GCS_BUCKET/logs/" >/dev/null 2>"$gcs_error"; then
echo "GCS: gsutil ls -b gs://$GCS_BUCKET"
if /opt/gsutil/bin/gsutil ls -b "gs://$GCS_BUCKET" >/dev/null 2>"$gcs_error"; then

@stackrox-openshell-workflow stackrox-openshell-workflow Bot Sep 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check no longer verifies the existence of the logs subdirectory, only the bucket itself. This seems like a weaker preflight check that could allow subsequent steps to fail if they depend on that directory. Is this change intended?

echo "GCS: PASS"
else
gcs_status=$?
Expand Down
Loading