[SDK Sentinel] Stabilize workflow memo visibility test - #3077
Open
sdk-sentinel-bot wants to merge 1 commit into
Open
sdk-sentinel-bot wants to merge 1 commit into
sdk-sentinel-bot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
Stabilize the CLI-backed workflow memo visibility test. The [last preceding main success](https://github.com/temporalio/sdk-java/actions/runs/34899578848) was followed by the [first captured failing run](https://github.com/temporalio/sdk-java/actions/runs/35023355372), whose [CLI evidence](https://github.com/temporalio/sdk-java/actions/runs/35023355372/job/104564322183) timed out inside the visibility delay. No public API, breaking, or server change is involved.
Root cause
Workflow execution and an unconditional four-second sleep shared the rule's ten-second deadline. Under suite load, the deadline expired during the sleep before the eventually consistent Visibility API was queried.
Fix
Poll visibility with a bounded assertion until the execution is indexed, and give this external-service test a 30-second overall budget. The memo assertions remain unchanged.
Validation
The focused Java 11 CLI-backed test passed 3/3, plus five additional focused attempts. The unchanged baseline validator passed. Candidate validation was blocked by read-only submodule Git metadata; an equivalent formatting and compilation check passed with those unrelated tasks excluded. The Java 11 CLI job and fixed validator remain required.
Validation status:
validation-incompletehighhighmediumstandard— 1 changed file; 2.4 KiBnot-reproduced— One pre-change focused loopback attempt passed; the CI timeout was not reproduced naturally.pass-after-only— The existing focused test passed 3/3 in the failing Java 11 CLI mode and 5/5 additional attempts after the change.Gradle formatting and test-source compilation) — passedGradle formatting and test-source compilation) — did not pass (failure)Investigator-run checks
USE_EXTERNAL_SERVICE=true TEMPORAL_SERVICE_ADDRESS=127.0.0.1:7233 ./gradlew --offline --no-daemon :temporal-sdk:test -PtestJavaVersion=11 --tests "io.temporal.functional.serialization.WorkflowIdSignedPayloadsTest.testSimpleWorkflowWithMemo" -x :temporal-serviceclient:updateSubmodules -x :temporal-serviceclient:initSubmodules -x :temporal-sdk:compileJava17Java -x :temporal-sdk:java17Classes— passed; 3 attempt(s). Passed 3/3 against the preloaded loopback Temporal CLI with the Java 11 test runtime.USE_EXTERNAL_SERVICE=true TEMPORAL_SERVICE_ADDRESS=127.0.0.1:7233 ./gradlew --offline --no-daemon :temporal-sdk:test --tests "io.temporal.functional.serialization.WorkflowIdSignedPayloadsTest.testSimpleWorkflowWithMemo" -x :temporal-serviceclient:updateSubmodules -x :temporal-serviceclient:initSubmodules -x :temporal-sdk:compileJava17Java -x :temporal-sdk:java17Classes— passed; 5 attempt(s). Passed 5/5 additional focused loopback stress attempts..ci-flake-runtime/input/validate.sh— failed; 1 attempt(s). Formatting passed, but validation stopped when updateSubmodules could not write read-only .git module metadata. The trusted unchanged baseline had passed../gradlew --offline --no-daemon spotlessCheck testClasses -x test -x :temporal-serviceclient:updateSubmodules -x :temporal-serviceclient:initSubmodules -x :temporal-sdk:compileJava17Java -x :temporal-sdk:java17Classes— passed; 1 attempt(s). The available formatting and compilation checks passed after excluding environment-blocked unrelated tasks.Required target CI
Residual risks
Automation provenance
5c9599df0ba8585b4439c465cc3084f607f591fbIf this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-09-15 21:36 UTC2026-09-15 21:36 UTC