Skip to content

[SDK Sentinel] Stabilize workflow memo visibility test #3077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sdk-sentinel-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[SDK Sentinel] Stabilize workflow memo visibility test #3077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions ...-sdk/src/test/java/io/temporal/functional/serialization/WorkflowIdSignedPayloadsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.temporal.functional.serialization;

import static io.temporal.testUtils.Eventually.assertEventually;
import static org.junit.Assert.*;
import static org.junit.Assume.assumeFalse;
import static org.junit.Assume.assumeTrue;
Expand Down Expand Up @@ -78,8 +79,8 @@ public void testSimpleWorkflowWithAnActivity() {
assertEquals("result", workflowStub.execute("input"));
}

@Test
public void testSimpleWorkflowWithMemo() throws InterruptedException {
@Test(timeout = 30_000)
public void testSimpleWorkflowWithMemo() {
assumeTrue(
"skipping as test server does not support list", SDKTestWorkflowRule.useExternalService);

Expand All @@ -95,16 +96,20 @@ public void testSimpleWorkflowWithMemo() throws InterruptedException {
String workflowId = execution.getWorkflowId();
String runId = execution.getRunId();

// listWorkflowExecutions is Visibility API
// Temporal Visibility has latency and is not transactional with the Server API call
Thread.sleep(4_000);

List<WorkflowExecutionMetadata> executions =
testWorkflowRule
.getWorkflowClient()
.listExecutions("WorkflowId = '" + workflowId + "' AND " + " RunId = '" + runId + "'")
.collect(Collectors.toList());
assertEquals(1, executions.size());
assertEventually(
Duration.ofSeconds(20),
() -> {
// Visibility is eventually consistent with workflow completion.
List<WorkflowExecutionMetadata> visibleExecutions =
testWorkflowRule
.getWorkflowClient()
.listExecutions(
"WorkflowId = '" + workflowId + "' AND " + " RunId = '" + runId + "'")
.collect(Collectors.toList());
assertEquals(1, visibleExecutions.size());
return visibleExecutions;
});
assertEquals(MEMO_VALUE, executions.get(0).getMemo(MEMO_KEY, String.class));
}

Expand Down