Skip to content

test(consumer): wait for transport metrics before assertions - #725

Open
sbalabanov wants to merge 1 commit into
mainfrom
wt/fix-consumer-observability-race
Open

sbalabanov wants to merge 1 commit into
mainfrom
wt/fix-consumer-observability-race

Conversation

@sbalabanov

Copy link
Copy Markdown
Contributor

Summary

Intent:

  • Remove a scheduling race that let consumer metrics tests snapshot before transport completion metrics were recorded.

Changes:

  • Stop the consumer before taking metric snapshots so worker draining synchronizes Ack, Nack, and Reject completion.
  • Preserve the existing metric assertions without sleeps, retries, or weaker expectations.

Generated by the 🪄 pr-create skill in devexp-agent-marketplace

Test Plan

Issues

Summary:
Intent:
- Remove a scheduling race that let consumer metrics tests snapshot before transport completion metrics were recorded.

Changes:
- Stop the consumer before taking metric snapshots so worker draining synchronizes Ack, Nack, and Reject completion.
- Preserve the existing metric assertions without sleeps, retries, or weaker expectations.

---

<sub>Generated by the 🪄 pr-create skill in devexp-agent-marketplace</sub>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sbalabanov
sbalabanov marked this pull request as ready for review September 17, 2026 22:47
@sbalabanov
sbalabanov requested review from a team and behinddwalls as code owners September 17, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants