Skip to content

test(consumer): wait for transport metrics before assertions #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbalabanov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(consumer): wait for transport metrics before assertions #725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions platform/consumer/consumer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,8 @@ func TestConsumer_ObservabilityTags(t *testing.T) {
deliveryChan <- mockDel
<-done

require.NoError(t, testC.Stop(30000))

snapshot := testScope.Snapshot()

histograms := snapshot.Histograms()
Expand Down Expand Up @@ -895,8 +897,6 @@ func TestConsumer_ObservabilityTags(t *testing.T) {
assert.NotContains(t, counter.Name(), duplicate)
}
}

_ = testC.Stop(30000)
})
}
}
Expand Down Expand Up @@ -989,6 +989,9 @@ func TestConsumer_AckLifecycleMetrics(t *testing.T) {
deliveryChan <- mockDel
<-done

err = c.Stop(30000)
require.NoError(t, err)

snapshot := scope.Snapshot()
histograms := snapshot.Histograms()
var foundAck bool
Expand All @@ -999,9 +1002,6 @@ func TestConsumer_AckLifecycleMetrics(t *testing.T) {
}
}
assert.True(t, foundAck, "Should have successful ack.finish metric")

err = c.Stop(30000)
require.NoError(t, err)
}

func TestConsumer_NackLifecycleMetrics(t *testing.T) {
Expand Down Expand Up @@ -1043,6 +1043,9 @@ func TestConsumer_NackLifecycleMetrics(t *testing.T) {
deliveryChan <- mockDel
<-done

err = c.Stop(30000)
require.NoError(t, err)

snapshot := scope.Snapshot()
histograms := snapshot.Histograms()
var foundNackError bool
Expand All @@ -1053,9 +1056,6 @@ func TestConsumer_NackLifecycleMetrics(t *testing.T) {
}
}
assert.True(t, foundNackError, "Should have failed nack.finish metric")

err = c.Stop(30000)
require.NoError(t, err)
}

// TestConsumer_PerPartitionProcessing verifies that a slow message on partition A
Expand Down
Loading